Re: [Datetime-SIG] PEP-495 - Strict Invalid Time Checking
On 08/25/2015 03:01 PM, Alexander Belopolsky wrote:
On Tue, Aug 25, 2015 at 4:48 PM, Carl Meyer <carl@oddbird.net <mailto:carl@oddbird.net>> wrote:
If you accept this, and still think that the best API datetime can provide is "localize twice and figure it out yourself", I'm not interested in arguing the point.
Trust me, I considered many other options, but I have 4000+ lines of datetime unit tests that I cannot break. If you can come up with a patch that does what you want and passes python -m test test_datetime - I would certainly like to see it.
I don't understand why it seems like you continue to interpret all requests for an opt-in way to raise an exception as requests to change the default, which nobody is contemplating. I can't imagine how raising an exception on invalid times only if a non-default sentinel value is given for a flag that is _new in PEP 495_ could possibly break 4000 lines of existing datetime tests. Carl
On Tue, Aug 25, 2015 at 5:04 PM, Carl Meyer <carl@oddbird.net> wrote:
I can't imagine how raising an exception on invalid times only if a non-default sentinel value is given for a flag that is _new in PEP 495_ could possibly break 4000 lines of existing datetime tests.
OK, so datetime module itself will never set fold=-1. In the list below, can you mark the methods that need to be patched to check the fold attribute in your preferred design: datetime.__add__ datetime.__eq__ datetime.__format__ datetime.__ge__ datetime.__gt__ datetime.__hash__ datetime.__le__ datetime.__lt__ datetime.__ne__ datetime.__new__ datetime.__radd__ datetime.__reduce__ datetime.__reduce_ex__ datetime.__repr__ datetime.__rsub__ datetime.__str__ datetime.astimezone datetime.combine datetime.ctime datetime.date datetime.dst datetime.fromordinal datetime.fromtimestamp datetime.isocalendar datetime.isoformat datetime.isoweekday datetime.now datetime.replace datetime.strftime datetime.strptime datetime.time datetime.timestamp datetime.timetuple datetime.timetz datetime.today datetime.toordinal datetime.tzname datetime.utcfromtimestamp datetime.utcnow datetime.utcoffset datetime.utctimetuple datetime.weekday Please ask Isaac and Stuart to do the same. Once you agree on a list, let's continue this discussion.
participants (2)
-
Alexander Belopolsky -
Carl Meyer