On Sat, Nov 21, 2015 at 08:52 +0100, Florian Schulze wrote:
On 20 Nov 2015, at 22:23, holger krekel wrote:
- fix py2 incompatibility introduced with 2.5.1 where we used a unicode header and pyramid only likes str-headers.
Why didn't the tox runs catch this? My guess is, that the testing which works on the wsgi level didn't reach the place in Pyramid where this is an issue? If I remember correctly, this isn't even a Pyramid issue, but the traceback happens in waitress, right?
yes, i think waittress needed to be involved. Our tests are not functional enough. I guess BlueYonder's acceptance tests would catch it, though. It's clear we need to have a fully functional (system) test suite and i've filed an issue with their's acceptance test suite: https://github.com/blue-yonder/devpi-acceptancetests/issues/9 holger