Mailman 3 October 2006 - Distutils-SIG

Re: [Distutils] [kid-discuss] installing without setuptools
by John J Lee Oct. 14, 2006

Oct. 14, 2006

Apologies for being unable to resist going over old ground by responding to this (moved here from the kid mailing list). On Sat, 14 Oct 2006, Python wrote: > On Fri, 2006-10-13 at 22:25 +0100, John J Lee wrote: >> On Fri, 13 Oct 2006, Python wrote: >> [...] >>> I've also had grief with easy_install >>> many options did not seem to work >> >> Which ones? > > I can't say now. It seemed to be differences within packages and my > computer environment. I did not keep careful notes. [...] > Phillip suggested > -meb. > which finally worked, but was not obvious from the docs. I see. ISTM that the reason you had trouble is that you had your own ideas about how things should work, rather than following the standard setuptools way of doing things (which it certainly seems weren't arbitrarily chosen, but followed from actual, carefully considered, requirements). It's fair enough to do things your way, but one must always expect to need to expend a bit of effort in trade for "do it *my* way, not the standard way", IMNSHO. You don't get everything for free. OTOH, I don't think I ever managed to get vanilla distutils to install things anywhere but site-packages (admittedly I didn't have a serious need for it, so I gave up after a few attempts), and in contrast I think I managed to do it on my first attempt when using easy_install. So maybe you solved that puzzle with plain-distutils and consider "install it in this directory, I'll be responsible for putting it on sys.path" part of the standard distutils experience... But as I said on the kid list, you're right that easy_install would benefit from more tightly end-user targetted docs (and ISTR PJE hopes to write some later). [slightly re-ordered from original post] > Even the "just download the package and do nothing" option failed. Why is that an "Even"? Downloading the package is bound to fail sometimes given that setuptools tries to support old or uncooperative systems like Sourceforge, arbitrary distutils projects (which can do their own thing with naming conventions), and (ISTR) loosely-defined semantics of standard setup.py parameters like download_url. If you dislike that feature, do not use it. I guess ease of use is subjective, but when I tried it yesterday -- to help out on the kid list -- I found I needed no docs other than easy_install --help to figure out that I could just download stuff myself and run "easy_install --no-deps <stuff>" (again, sure, "-meb." is NOT obvious -- that's the price of doing stuff your own way, and not a terribly high price as it goes, ISTM). >>> other things simply went wrong Would be nice to know what, if not already reported. [...] >>> The operation is rather opaque and the documentation kind of assumed the >>> simple cases just worked. When operations fail, the trouble shooting >>> steps are not obvious. >> >> it's obvious with plain-distutils? You're a better programmer than I am >> :-) > I doubt it. > > All of the files and configuration info for distutils is in > understandable file formats. eggs are rather difficult if you can't get > the egg manipulation tools to work. [...] But most .eggs, as I understand it, are just .zip files, with a directory inside containing arbitrary metadata files, with some standard metadata for setuptools, which is documented: http://peak.telecommunity.com/DevCenter/EggFormats (only "most" eggs because some are unzipped, and some are implemented with an .egg-info link -- both of which are also documented above) John

1 0

Re: [Distutils] your setuptools egg seems have a "Trojan" virus
by Phillip J. Eby Oct. 13, 2006

Oct. 13, 2006

At 03:06 PM 10/13/2006 +0800, æç»ç§' wrote: >hi, > I got a virus warning when I Dodnloading "setuptools-0.6c3-py2.5.egg.zip" > "TrojanSpy.Delf.s" , > can you check the "stuptools" zip file No, I can't, since I don't know what you mean by "check". I don't know what TronjanSpy.Delf.s *is*. Note that I built the current cheeseshop release of setuptools on a *Linux* machine, so I don't think there's any way it can be infected with a Windows virus. The only possible vector for that would be if the cli.exe and gui.exe files were affected, since I build those on Windows. So if that was what the warning was about, let me know. Otherwise, you should report this as a false positive to your antivirus vendor, so that they can fix their program. It's likely that it is seeing some random data in the zipfile that happens to resemble some portion of the trojan in question.

1 0

your setuptools egg seems have a "Trojan" virus
by 慕登科 Oct. 13, 2006

Oct. 13, 2006

hi, I got a virus warning when I Dodnloading "setuptools-0.6c3-py2.5.egg.zip" "TrojanSpy.Delf.s" , can you check the "stuptools" zip file this is the detailed, I download the Dajango 0.95 from their official site DJangoproject.com but install didn't work because the"ez_setup.py" is a old version so i got a new version at"http://peak.telecommunity.com/DevCenter/setuptools" this time it goes well but when it downloading "setuptools-0.6c3-py2.5.egg" I GOT that Trojan virus warning. I think it's impossible ,anyway plese check this url"http://cheeseshop.python.org/packages/2.5/s/setuptools/setuptools-0.6c3-py2…"

1 0

Professional Grant Proposal Writing Workshop (University of Washington, Seattle - December 2006)
by Anthony Jones Oct. 13, 2006

Oct. 13, 2006

1 0

Re: [Distutils] Distutils-SIG Digest, Vol 42, Issue 14
by Brian Kirsch Oct. 12, 2006

Oct. 12, 2006

Hi Jeff, I presented last year at PyCon a talk on Internationalizing Chandler. As part of OSAF's effort to provide a clean an easy to use internationalization framework for Python, we developed the EggTranslations API which was completed about two months ago. This API written as an egg provides a framework for other eggs to easily localize. The EggTranslations API is currently leveraged in our product Chandler (www.osafoundation.org) and has proved to be easy to use and extremely effective. I think a standalone talk on EggTranslations would be both a great follow up to last year's Internationalizing Chandler presentation and very much in line with this years PyCon focus on Python eggs. More info on EggTranslations is provided here in the README: http://websvn.osafoundation.org/filedetails.php?repname=chandler&path=%2Ftr… Here is a link to the source which contains detailed API documentation: http://websvn.osafoundation.org/filedetails.php?repname=chandler&path=%2Ftr… Thanks, Brian -- Brian Kirsch Internationalization Architect / Mail Service Engineer Open Source Applications Foundation 543 Howard Street 5th Floor San Francisco, CA 94105 http://www.osafoundation.org distutils-sig-request(a)python.org wrote: > Send Distutils-SIG mailing list submissions to > distutils-sig(a)python.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://mail.python.org/mailman/listinfo/distutils-sig > or, via email, send a message with subject or body 'help' to > distutils-sig-request(a)python.org > > You can reach the person managing the list at > distutils-sig-owner(a)python.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Distutils-SIG digest..." > > > Today's Topics: > > 1. A Call for a Presenter on Python Eggs (Jeff Rush) > 2. Re: A Call for a Presenter on Python Eggs (Phillip J. Eby) > 3. A Call for a Presenter on Python Eggs (Jeff Rush) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Wed, 11 Oct 2006 10:01:53 -0500 > From: Jeff Rush <jeff(a)taupro.com> > Subject: [Distutils] A Call for a Presenter on Python Eggs > To: python-announce-list(a)python.org, python-list(a)python.org, > distutils-sig(a)python.org, dfwpython(a)dfwpython.org > Message-ID: <452D0761.3020104(a)taupro.com> > Content-Type: text/plain; charset=ISO-8859-1 > > Eggs are important to Python and will become more so over the next few years, > if understood and embraced by the community. They are a key competitive > feature - I've been asked so many times what is the Python equivalent to CPAN > and finally we're developing an answer. > > At PyCon 2007 we need a solid set of talks about eggs, broken down into just > using them, how to build and distribute them, and then an advanced talk on > some of the more exotic aspects of eggs. At PyCon 2006, essentially the 3rd > talk I mention above was given to a standing-room-only audience, and then > repeated against an hour later as people in the hall could not get in. But > missing were the first two talks - many people were not ready for advanced > material but sought an introduction. > > Who in our community is building eggs on a frequent basis, and is good at > explaining how they work? > > Below are three talk outlines I've sketched out, along with the slides from a > talk I tossed together for the Dallas Pythoneers group. They need polish and > I'm donating them to the cause. > > Will someone please step forward and address this critical need? > > For revision, links to the three wiki outline pages appear on: > http://us.pycon.org/TX2007/TalkIdeas > > --- > Python Eggs - Using and Installing Them > > * What is so cool about eggs? Wow me. > * What problem were they intended to solve? > * What is their relation to distutils? > * So how does distutils work then? > * How do they compare to CPAN and RPM approaches? > * Sound good, how do I enable eggs on my system? > * How do I accomplish common operations? > o install an egg > o test install an egg, to see if it would work > o uninstall an egg > o list what eggs are installed at the moment > o switch between the versions of an egg > * I don't trust eggs - how can I partially install one, > examine it and then finish the installation? > * How do I find out what eggs exist, and their names? > * What about py2exe and droplets? Competing approaches? > * Show me a walkthru of the cheeseshop - how to find a package. > * How do I figure out the author of an egg I'm having trouble with? > > --- > Python Eggs - Creating and Distributing Them > > * Where does distutils fit in? > * What do I need to add to setup.py to package my software as an egg? > * How does it work re path configuration files? > * What are the issues with zipped eggs; how can my code access my data? > * How do I produce cross-platform eggs? > * How do I produce platform-specific eggs? > * How do I get my eggs registered on the cheeseshop? > * How do I upload my eggs, source and binaries? > * How can I volunteer as a packager for non-egg authors? > * Some eggs are broken in the cheeseshop - how can I help? > > (Keep this talk simple and focused on _just_ getting your vanilla egg packaged > and uploaded. Defer the advanced egg issues to the third talk). > > --- > Python Eggs - Advanced Packaging > > * What are entry points? > * How does dynamic discovery/plugins work? > * I hear Trac uses them - how? > * What are extras? They sound nifty! > * What is a namespace package? When and how do I use them? > * How can I have multiple distribution versions? > * I hear eggs can detect files under CVS/subversion > control - how does that work? > * Also eggs have support for units tests - how? > * Where do the egg experts hang out? > > An Old Talk of mine about Eggs (from which to borrow slides/ideas): > > * Attach:2006-03-25-AboutPythonEggs.odt > * Attach:2006-03-25-AboutPythonEggs.pdf > > -Jeff > Co-Chair PyCon 2007 > > > ------------------------------ > > Message: 2 > Date: Wed, 11 Oct 2006 11:35:04 -0400 > From: "Phillip J. Eby" <pje(a)telecommunity.com> > Subject: Re: [Distutils] A Call for a Presenter on Python Eggs > To: Jeff Rush <jeff(a)taupro.com>, distutils-sig(a)python.org > Message-ID: > <5.1.1.6.0.20061011112731.0273d698(a)sparrow.telecommunity.com> > Content-Type: text/plain; charset="us-ascii"; format=flowed > > On all of these items, I can certainly help with providing answers to > questions that a speaker may or may not know about currently. I don't know > if I will be able to give any talks myself; my PyCon plans (if any) are not > finalized yet. > > I do suggest you ask Kevin Dangoor and Ian Bicking if they are interested; > both of them are good at presenting the stuff I dreamed up a year or so > before, whereas I tend to present stuff I'm still in the middle of > developing. :) > > I also think you might need to break the first talk into two talks, unless > the timeslots for talks have expanded significantly this year. :) > > At 10:01 AM 10/11/2006 -0500, Jeff Rush wrote: > >> Python Eggs - Using and Installing Them >> >> * What is so cool about eggs? Wow me. >> * What problem were they intended to solve? >> * What is their relation to distutils? >> * So how does distutils work then? >> * How do they compare to CPAN and RPM approaches? >> * Sound good, how do I enable eggs on my system? >> * How do I accomplish common operations? >> o install an egg >> o test install an egg, to see if it would work >> o uninstall an egg >> o list what eggs are installed at the moment >> o switch between the versions of an egg >> * I don't trust eggs - how can I partially install one, >> examine it and then finish the installation? >> * How do I find out what eggs exist, and their names? >> * What about py2exe and droplets? Competing approaches? >> * Show me a walkthru of the cheeseshop - how to find a package. >> * How do I figure out the author of an egg I'm having trouble with? >> > > > > ------------------------------ > > Message: 3 > Date: Wed, 11 Oct 2006 10:01:53 -0500 > From: Jeff Rush <jeff(a)taupro.com> > Subject: [Distutils] A Call for a Presenter on Python Eggs > To: python-announce-list(a)python.org, python-list(a)python.org, > distutils-sig(a)python.org, dfwpython(a)dfwpython.org > Message-ID: <452D0761.3020104(a)taupro.com> > Content-Type: text/plain; charset="us-ascii" > > Eggs are important to Python and will become more so over the next few years, > if understood and embraced by the community. They are a key competitive > feature - I've been asked so many times what is the Python equivalent to CPAN > and finally we're developing an answer. > > At PyCon 2007 we need a solid set of talks about eggs, broken down into just > using them, how to build and distribute them, and then an advanced talk on > some of the more exotic aspects of eggs. At PyCon 2006, essentially the 3rd > talk I mention above was given to a standing-room-only audience, and then > repeated against an hour later as people in the hall could not get in. But > missing were the first two talks - many people were not ready for advanced > material but sought an introduction. > > Who in our community is building eggs on a frequent basis, and is good at > explaining how they work? > > Below are three talk outlines I've sketched out, along with the slides from a > talk I tossed together for the Dallas Pythoneers group. They need polish and > I'm donating them to the cause. > > Will someone please step forward and address this critical need? > > For revision, links to the three wiki outline pages appear on: > http://us.pycon.org/TX2007/TalkIdeas > > --- > Python Eggs - Using and Installing Them > > * What is so cool about eggs? Wow me. > * What problem were they intended to solve? > * What is their relation to distutils? > * So how does distutils work then? > * How do they compare to CPAN and RPM approaches? > * Sound good, how do I enable eggs on my system? > * How do I accomplish common operations? > o install an egg > o test install an egg, to see if it would work > o uninstall an egg > o list what eggs are installed at the moment > o switch between the versions of an egg > * I don't trust eggs - how can I partially install one, > examine it and then finish the installation? > * How do I find out what eggs exist, and their names? > * What about py2exe and droplets? Competing approaches? > * Show me a walkthru of the cheeseshop - how to find a package. > * How do I figure out the author of an egg I'm having trouble with? > > --- > Python Eggs - Creating and Distributing Them > > * Where does distutils fit in? > * What do I need to add to setup.py to package my software as an egg? > * How does it work re path configuration files? > * What are the issues with zipped eggs; how can my code access my data? > * How do I produce cross-platform eggs? > * How do I produce platform-specific eggs? > * How do I get my eggs registered on the cheeseshop? > * How do I upload my eggs, source and binaries? > * How can I volunteer as a packager for non-egg authors? > * Some eggs are broken in the cheeseshop - how can I help? > > (Keep this talk simple and focused on _just_ getting your vanilla egg packaged > and uploaded. Defer the advanced egg issues to the third talk). > > --- > Python Eggs - Advanced Packaging > > * What are entry points? > * How does dynamic discovery/plugins work? > * I hear Trac uses them - how? > * What are extras? They sound nifty! > * What is a namespace package? When and how do I use them? > * How can I have multiple distribution versions? > * I hear eggs can detect files under CVS/subversion > control - how does that work? > * Also eggs have support for units tests - how? > * Where do the egg experts hang out? > > An Old Talk of mine about Eggs (from which to borrow slides/ideas): > > * Attach:2006-03-25-AboutPythonEggs.odt > * Attach:2006-03-25-AboutPythonEggs.pdf > > -Jeff > Co-Chair PyCon 2007 >

1 0

A Call for a Presenter on Python Eggs
by Jeff Rush Oct. 11, 2006

Oct. 11, 2006

Eggs are important to Python and will become more so over the next few years, if understood and embraced by the community. They are a key competitive feature - I've been asked so many times what is the Python equivalent to CPAN and finally we're developing an answer. At PyCon 2007 we need a solid set of talks about eggs, broken down into just using them, how to build and distribute them, and then an advanced talk on some of the more exotic aspects of eggs. At PyCon 2006, essentially the 3rd talk I mention above was given to a standing-room-only audience, and then repeated against an hour later as people in the hall could not get in. But missing were the first two talks - many people were not ready for advanced material but sought an introduction. Who in our community is building eggs on a frequent basis, and is good at explaining how they work? Below are three talk outlines I've sketched out, along with the slides from a talk I tossed together for the Dallas Pythoneers group. They need polish and I'm donating them to the cause. Will someone please step forward and address this critical need? For revision, links to the three wiki outline pages appear on: http://us.pycon.org/TX2007/TalkIdeas --- Python Eggs - Using and Installing Them * What is so cool about eggs? Wow me. * What problem were they intended to solve? * What is their relation to distutils? * So how does distutils work then? * How do they compare to CPAN and RPM approaches? * Sound good, how do I enable eggs on my system? * How do I accomplish common operations? o install an egg o test install an egg, to see if it would work o uninstall an egg o list what eggs are installed at the moment o switch between the versions of an egg * I don't trust eggs - how can I partially install one, examine it and then finish the installation? * How do I find out what eggs exist, and their names? * What about py2exe and droplets? Competing approaches? * Show me a walkthru of the cheeseshop - how to find a package. * How do I figure out the author of an egg I'm having trouble with? --- Python Eggs - Creating and Distributing Them * Where does distutils fit in? * What do I need to add to setup.py to package my software as an egg? * How does it work re path configuration files? * What are the issues with zipped eggs; how can my code access my data? * How do I produce cross-platform eggs? * How do I produce platform-specific eggs? * How do I get my eggs registered on the cheeseshop? * How do I upload my eggs, source and binaries? * How can I volunteer as a packager for non-egg authors? * Some eggs are broken in the cheeseshop - how can I help? (Keep this talk simple and focused on _just_ getting your vanilla egg packaged and uploaded. Defer the advanced egg issues to the third talk). --- Python Eggs - Advanced Packaging * What are entry points? * How does dynamic discovery/plugins work? * I hear Trac uses them - how? * What are extras? They sound nifty! * What is a namespace package? When and how do I use them? * How can I have multiple distribution versions? * I hear eggs can detect files under CVS/subversion control - how does that work? * Also eggs have support for units tests - how? * Where do the egg experts hang out? An Old Talk of mine about Eggs (from which to borrow slides/ideas): * Attach:2006-03-25-AboutPythonEggs.odt * Attach:2006-03-25-AboutPythonEggs.pdf -Jeff Co-Chair PyCon 2007

2 1

Re: [Distutils] compiler selection with bdist_egg of setuptools
by Venkat Bommakanti Oct. 11, 2006

Oct. 11, 2006

>>If I knew where gcc/and-its-options were being >>ascertained, config'd, and used, then I could theoretically intervene and have >>it point to my gcc and use my settings for it... >> >>Again, Philip, thanks a bunch for all the time you've spent helping me on >>this. >>/venkat >No problem, just remember that neither distutils nor setuptools officially >provide any support whatsoever for cross-compilation. If you actually >succeed in getting something to work, I suggest writing up a HowTo or at >least a description of what you ended up doing, so that others can benefit >from your trials. I'm getting closer to this, albeit in baby steps... :-) Will surely write one up - as soon as I have this working. If this doesn't workout, may have to just unpack the distros, use makefiles for each and build the cross .so's that ways... Was hoping to levelrage all the work that has already gone into distutils / setuptools. Thanks again, /venkat

1 0

Re: [Distutils] compiler selection with bdist_egg of setuptools
by Venkat Bommakanti Oct. 11, 2006

Oct. 11, 2006

>>While compiling some py/C source pkgs, such as: >> . RuleDispatch-0.5a0.dev-r2115.tar.gz >> . cElementTree-1.0.5-20051216.zip >> . PyProtocols-1.0a0dev_r2082.zip >> . Cheetah-2.0rc7.tar.gz >>I noticed in the logs that each (after being unpacked) has >>the following command invoked: >> setup.py -q bdist_egg --dist-dir /tmp/.... >> >>Since selecting a 'compiler' is not an option for the >>"bdist_egg" command, are even the settings in >>~/.pydistutils.cfg file: >> [build] >> compiler = unix >> [bdist_egg] >> plat_name = ppc >>picked up ? >> >>They appear not to be picked up, and I'm suspecting that >>since the [build] settings are valid only for the "build" command, >>it will not have any effect on the "bdist_egg" command used >>by all the above comps. Is that accurate ? >No, it's not accurate. bdist_egg invokes various build commands >(such as build_ext) which get their default --compiler setting from >the [build] configuration. I retried, this time with the same entries in the setup.cfg file of TG: [build] compiler = unix build_temp = <my_build_temp_dir> [bdist_egg] plat_name = ppc verbose = 1 keep_temp = 1 dist_dir = <my_dist_dir> I can see the verbose logs intially pick up all these settings: ... option dict for 'bdist_egg' command: {'dist_dir': ('setup.cfg', '<my_dist_dir>'), 'keep_temp': ('setup.cfg', '1'), 'plat_name': ('setup.cfg', 'ppc'), 'verbose': ('setup.cfg', '1')} but only "verbose=1" appears to be used. The comps are all invoked as part of TG's: easy_install -f . --prefix=my_usr -s my_usr/bin TurboGears but their respective setup commands get invoked as: setup.py -q bdist_egg --dist-dir /tmp/.... So, my attempts to specify/use from setup.cfg are getting overriden by the above "setup.py -q --dist..." call. This is the snippet that seems to indicate that: ... option dict for 'bdist_egg' command: {'dist_dir': ('command line', '/tmp/easy_install-3XaB58/RuleDispatch-0.5a0.dev-r2115/egg-dist-tmp-wG1geg')} ... >>If plat_name is not picked up, how is setuptools figuring >>out that the platform is i686 (given that the build is being >>done for a i686 linux box). Verbose logs don't show where/how >>that decision is made... >Try running with $DISTUTILS_DEBUG set to "yes". You will get a ton of >output showing what configuration files are being parsed and how the >options for each command are getting set. Look at what's happening when >the second-level setup is run (i.e., the package being asked to >'bdist_egg'); the first-level (easy_install itself) won't make any difference. I did set $DISTUTILS_DEBUG to "yes". Its unclear how/where the fact that its a "i686" platform is picked up frm... Taking the RuleDispatch comp as an example, the first inkling it is going to use "i686" is this log entry: ... installing library code to build/bdist.linux-i686/egg ... Its unclear how this was decided upon... Is it the platform on whicc the python itslef was build or is it the platform of the gcc (in the path) ? Also, what is unclear is how its being determined that the compiler is "gcc" and how its options are being set. Taking RuleDispatch again as an example, I see this: ... building 'dispatch._speedups' extension creating build/temp.linux-i686-2.4 creating build/temp.linux-i686-2.4/src creating build/temp.linux-i686-2.4/src/dispatch gcc -pthread -fno-strict-aliasing -DNDEBUG -g -O3 -Wall -Wstrict-prototypes -fPIC -I/<path-to-python-headers>/usr/include/python2.4 -c src/dispatch/_speedups.c -o build/temp.linux-i686-2.4/src/dispatch/_speedups.o gcc -pthread -shared build/temp.linux-i686-2.4/src/dispatch/_speedups.o -o build/lib.linux-i686-2.4/dispatch/_speedups.so ... I looked in python, setuptools & RulesDisptach sources, but couldn't find the answers to these questions. If I knew where gcc/and-its-options were being ascertained, config'd, and used, then I could theoretically intervene and have it point to my gcc and use my settings for it... Again, Philip, thanks a bunch for all the time you've spent helping me on this. /venkat

2 1

gcc compiler options' override
by Venkat Bommakanti Oct. 11, 2006

Oct. 11, 2006

Hi, For a couple comps, like: . RuleDispatch-0.5a0.dev-r2115.tar.gz . cElementTree-1.0.5-20051216.zip, ... I'm trying to build and deploy them as eggs... Using the $CC override, I'm able specify the compiler of choice to compile the C sources in these comps. How do I select the compiler options ( -I, -L, -D etc) and have them picked up by the compiler (--compiler=unix) which in turn could be used by distutils.unixcompiler... Thanks, /venkat

2 1

setuptools: ALL source tree?
by Pierre Imbaud Oct. 10, 2006

Oct. 10, 2006

Trying to put setuptools to work, from the svn workspace, with no previous experience of distutils or setuptools (previously had a script making a tarball). As often happens with very good tools, very well documented, some very simple, yet vital pieces of information is missing for the newcomer. my source tree: root setup.py package scripts test doc I dont want to distribute test: internal non-regression tools and data. dont want to distribute doc either. I found NO WAY, with setup.py at the top, to get these files out of the tarball. Am I supposed to make ONE tree with all I want to distribute, and all I dont want distributed in some other tree? Like: root dist setup.py package scripts test doc Its no big deal, Im redesigning the layering. But then, the only way to say: "I dont want this distributed any more" is by moving the file? Or did I miss some point? Thanks for answering

2 2