OK, now we're talking. You have given me a test case that makes my patch fail and I will address it after How I Met Your Mother.
El Jueves 12 Marzo 2009, Gerry Reno escribió:
> In RPM the only restriction on 'version' is that it must be made of
> alphanumeric or period. Ref:
> Just for a small test I ran a perfectly legal version pattern, that is
> allowable in distros other than Fedora, through your patch logic.
> version = A2
> release = 0_rc1
> version-release = A2-0_rc1 # this is what we expected to see
> version-release = -0.0_rc1.A2 # this is what we get instead as strings
> are modified by patch logic
> This is why I suggest that you make an extension module triggered by a
> commandline option so there are no restrictions or unexpected
> side-effects introduced to non-Fedora distro users.
> Right now, I'm a big -1 on the patch. If it would be made as an
> extension triggered by commandline option then I would support it.
Manuel Amador (Rudd-O) <firstname.lastname@example.org>
Rudd-O.com - http://rudd-o.com/
GPG key ID 0xC8D28B92 at http://wwwkeys.pgp.net/
There is nothing more permanent than a temporary building.
There is nothing more permanent than a temporary tax.