What's a postinstall script supposed to return or exit with to indicate success or failure, anyway? It should return 0 as the exit code.
Thanks. What if there's actually an error? Just throw an exception?
Installer will look for a non-zero exit. It will display it as "a action has failed". So how you arrive at the non-zero exit code is irrelevant.
I was wondering about that. There's this clause in add_find_python:
add_data(self.db, "CustomAction", [("PythonFromMachine", 51+256, "PYTHONDIR", "[PYTHON.MACHINE]"), ("PythonFromUser", 51+256, "PYTHONDIR", "[PYTHON.USER]"), ("PythonExe", 51+256, "PYTHON", "[PYTHONDIR]\\python.exe"), ("InitialTargetDir", 51+256, "TARGETDIR", "[PYTHONDIR]")])
and the backslash there seems redundant. Changing it to "[PYTHONDIR]python.exe" removes the extra backslash in the value of PYTHON. Shall I file a patch?
Sure. Please indicate whether this is just cosmetical (and if so, better file a patch for trunk, which has that code changed). Regards, Martin