At 11:25 AM 9/29/04 -0600, Sean Reifschneider wrote:
On Tue, Sep 28, 2004 at 12:44:34AM +0800, Jeff Pitman wrote:
I'm new here. I submitted a patch for your kind review that spews out an RPM-consumable list including %dir and %lang attributes. The concept could be expanded further.
Any comments on this patch? symbiont has been doing a lot of work with RPMs, and has run into some issues where he needs some more features than the normal record file provides. Any objections to my accepting this patch?
Isn't distutils supposed to be compatible with older versions of Python, e.g. 1.5.2? The list comprehension won't work, and it removes a minor optimization ('if self.root:'). I don't see an issue with adding the feature, or in moving the write-record facility to a separate method, but the changes to existing feature(s) should be reversed, IMO.