sdist's default file list looks incomplete
hi there, When generating a distribution, a list of files to be included is needed. This list is either provided by the packager (a 'MANIFEST' file), or it is generated by distutils from its limitted knowledge coming from existing commands. The documentation for sdist.get_defaults() states: "Add all the default files to self.filelist: - README or README.txt - setup.py - test/test*.py - all pure Python modules mentioned in setup script - all C sources listed as part of extensions or C libraries in the setup script (doesn't catch C headers!) Warns if (README or README.txt) or setup.py are missing; everything else is optional." I'm wondering why this list is lacking the scripts and data files that I can provide to setup(). They clearly are part of a distribution, and they are known to the distribution object, so they could be computed here. Is that a deliberate choice or an omission ? If the former, why ? If the latter, should I send in a patch ? (where ?) Regards, Stefan
On Thu, Aug 28, 2003 at 09:38:20AM -0400, Stefan Seefeld wrote:
here. Is that a deliberate choice or an omission ? If the former, why ? If the latter, should I send in a patch ? (where ?)
Probably an accidental omission -- most projects have a MANIFEST or MANIFEST.in, so no one thought to add it. You can submit a patch to the Python project patch tracker on SourceForge. --amk
A.M. Kuchling wrote:
On Thu, Aug 28, 2003 at 09:38:20AM -0400, Stefan Seefeld wrote:
here. Is that a deliberate choice or an omission ? If the former, why ? If the latter, should I send in a patch ? (where ?)
Probably an accidental omission -- most projects have a MANIFEST or MANIFEST.in, so no one thought to add it. You can submit a patch to the Python project patch tracker on SourceForge.
ok, will do, thanks. Regards, Stefan
the distribution has a 'headers' attribute that is used in 'install_headers'. Where is that attribute set from ? In the current design I would expect 'Extension' to set them, but they don't contain them... Regards, Stefan
On Thu, Aug 28, 2003 at 10:24:29AM -0400, Stefan Seefeld wrote:
the distribution has a 'headers' attribute that is used in 'install_headers'. Where is that attribute set from ? In the current design I would expect 'Extension' to set them, but they don't contain them...
It would be set by the call to setup(): setup(..., headers=["NumPy.h"], ...) The code that does it would be at the end of the Distribution.__init__ method (around line 230 or so of dist.py). --amk
participants (2)
-
A.M. Kuchling -
Stefan Seefeld