static libs, unixccompiler.py, darwin
A while back I posted about Darwin (OSX) needs to run ranlib when creating static libraries. I've created a patch and wanted to run it by you guys. Does the patch below look reasonable? Thanks, Just Index: unixccompiler.py =================================================================== RCS file: /cvsroot/python/python/dist/src/Lib/distutils/unixccompiler.py,v retrieving revision 1.38 diff -c -3 -r1.38 unixccompiler.py *** unixccompiler.py 2001/12/11 05:04:24 1.38 --- unixccompiler.py 2002/02/05 21:26:44 *************** *** 17,23 **** __revision__ = "$Id: unixccompiler.py,v 1.38 2001/12/11 05:04:24 fdrake Exp $" ! import string, re, os from types import * from copy import copy from distutils import sysconfig --- 17,23 ---- __revision__ = "$Id: unixccompiler.py,v 1.38 2001/12/11 05:04:24 fdrake Exp $" ! import string, re, os, sys from types import * from copy import copy from distutils import sysconfig *************** *** 61,66 **** --- 61,69 ---- 'archiver' : ["ar", "-cr"], 'ranlib' : None, } + + if sys.platform.startswith("darwin"): + executables['ranlib'] = ["ranlib"] # Needed for the filename generation methods provided by the base # class, CCompiler. NB. whoever instantiates/uses a particular
From: "Just van Rossum" <just@letterror.com>
+ + if sys.platform.startswith("darwin"): + executables['ranlib'] = ["ranlib"]
Also looks harmless to me, although I would prefer something *not* using string methods, so that compatibility to 1.5.2 is retained (does anyone care besides myself?). Thomas
Thomas Heller wrote:
From: "Just van Rossum" <just@letterror.com>
+ + if sys.platform.startswith("darwin"): + executables['ranlib'] = ["ranlib"]
Also looks harmless to me, although I would prefer something *not* using string methods, so that compatibility to 1.5.2 is retained (does anyone care besides myself?).
I do and since many people are still using 1.5.2 we should keep distutils 1.5.2-safe for at least a few more rounds. -- Marc-Andre Lemburg CEO eGenix.com Software GmbH ______________________________________________________________________ Company & Consulting: http://www.egenix.com/ Python Software: http://www.egenix.com/files/python/
On Wed, 6 Feb 2002, M.-A. Lemburg wrote:
Thomas Heller wrote:
From: "Just van Rossum" <just@letterror.com>
+ + if sys.platform.startswith("darwin"): + executables['ranlib'] = ["ranlib"]
Also looks harmless to me, although I would prefer something *not* using string methods, so that compatibility to 1.5.2 is retained (does anyone care besides myself?).
I do and since many people are still using 1.5.2 we should keep distutils 1.5.2-safe for at least a few more rounds.
Ditto. I've got some HP's that are being "deprecated", so I don't want to fight getting python 2 packaged and rolled out. I'm just now getting 2 to my Solaris boxes because of all the dependencies I've got. Based on my experience, 1.5.2 is going to be around a while on non-linux platforms. mwa
participants (4)
-
Just van Rossum
-
M.-A. Lemburg
-
Mark W. Alexander
-
Thomas Heller