Hi, Roland added some pep8 fixes for buildout's bootstrap file: https://github.com/buildout/buildout/pull/77 When I'm looking at buildout's code, my hands are sometimes itching to run pep8 (and pyflakes) over it. Nothing major, just visual stuff. The good thing about that: it looks better and more modern. The bad thing about that: it could wreak some havoc with existing pull requests. The list of 'em is getting smaller and smaller every week, so it shouldn't be too much hassle. I'd love to do the work, but only if it stands a chance of inclusion :-) If so, I'll first do one file and gather feedback. Basically, I'm only going to fix what pep8 (the script) reports. Reinout -- Reinout van Rees http://reinout.vanrees.org/ reinout@vanrees.org http://www.nelen-schuurmans.nl/ "If you're not sure what to do, make something. -- Paul Graham"
On Sat, Feb 16, 2013 at 3:18 PM, Reinout van Rees
Hi,
Roland added some pep8 fixes for buildout's bootstrap file: https://github.com/buildout/buildout/pull/77
When I'm looking at buildout's code, my hands are sometimes itching to run pep8 (and pyflakes) over it. Nothing major, just visual stuff.
The good thing about that: it looks better and more modern.
The bad thing about that: it could wreak some havoc with existing pull requests. The list of 'em is getting smaller and smaller every week, so it shouldn't be too much hassle.
I'd love to do the work, but only if it stands a chance of inclusion :-) If so, I'll first do one file and gather feedback. Basically, I'm only going to fix what pep8 (the script) reports.
+1 Pep8 deviations are mostly unintentional. The only caveat is that pep8's grouping of imports is silly. :) I prefer to import one module (like pep8) per line and to sort the imports. Also, please don't introduce more from imports. I only use them in extreme circumstances as they hurt code readability in most cases in my opinion. Jim -- Jim Fulton http://www.linkedin.com/in/jimfulton Jerky is better than bacon! http://zo.pe/Kqm
participants (2)
-
Jim Fulton
-
Reinout van Rees