Amend PEP 440 with Wider Feedback on Release Candidates
I’ve had a number of people complain that PEP 440 normalizes a release candidate as 1.0c1 instead of 1.0rc1. Do we want to ammend the PEP to switch the normalization around so that it normalizes 1.0c1 to 1.0rc1? This probably matches what people expect better in general? It wouldn't have any effect on sort order or the like, it would just change which form is preferred. --- Donald Stufft PGP: 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA
On Dec 16, 2014, at 12:56 PM, Donald Stufft <donald@stufft.io> wrote:
I’ve had a number of people complain that PEP 440 normalizes a release candidate as 1.0c1 instead of 1.0rc1. Do we want to ammend the PEP to switch the normalization around so that it normalizes 1.0c1 to 1.0rc1? This probably matches what people expect better in general? It wouldn't have any effect on sort order or the like, it would just change which form is preferred.
--- Donald Stufft PGP: 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA
_______________________________________________ Distutils-SIG maillist - Distutils-SIG@python.org https://mail.python.org/mailman/listinfo/distutils-sig
Just so people know, here’s a PR to packaging that implements this https://github.com/pypa/packaging/pull/19. --- Donald Stufft PGP: 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA
On 16 December 2014 at 17:56, Donald Stufft <donald@stufft.io> wrote:
I’ve had a number of people complain that PEP 440 normalizes a release candidate as 1.0c1 instead of 1.0rc1. Do we want to ammend the PEP to switch the normalization around so that it normalizes 1.0c1 to 1.0rc1? This probably matches what people expect better in general? It wouldn't have any effect on sort order or the like, it would just change which form is preferred.
I'd typically expect to see 1.0rc1 rather than 1.0c1. I don't think it's a crisis either way, but I would mildly prefer it if this change was made. Paul
On Dec 16, 2014, at 2:51 PM, Paul Moore <p.f.moore@gmail.com> wrote:
On 16 December 2014 at 17:56, Donald Stufft <donald@stufft.io> wrote:
I’ve had a number of people complain that PEP 440 normalizes a release candidate as 1.0c1 instead of 1.0rc1. Do we want to ammend the PEP to switch the normalization around so that it normalizes 1.0c1 to 1.0rc1? This probably matches what people expect better in general? It wouldn't have any effect on sort order or the like, it would just change which form is preferred.
I'd typically expect to see 1.0rc1 rather than 1.0c1. I don't think it's a crisis either way, but I would mildly prefer it if this change was made. Paul
Given that it’s a fairly low impact change, We’ve got several pip developers +1 on it, Jason is OK with it on the setuptools side, and nobody has spoken out against it I’m going to go ahead and make this change. --- Donald Stufft PGP: 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA
On Dec 17, 2014, at 8:55 PM, Donald Stufft <donald@stufft.io> wrote:
On Dec 16, 2014, at 2:51 PM, Paul Moore <p.f.moore@gmail.com> wrote:
On 16 December 2014 at 17:56, Donald Stufft <donald@stufft.io> wrote:
I’ve had a number of people complain that PEP 440 normalizes a release candidate as 1.0c1 instead of 1.0rc1. Do we want to ammend the PEP to switch the normalization around so that it normalizes 1.0c1 to 1.0rc1? This probably matches what people expect better in general? It wouldn't have any effect on sort order or the like, it would just change which form is preferred.
I'd typically expect to see 1.0rc1 rather than 1.0c1. I don't think it's a crisis either way, but I would mildly prefer it if this change was made. Paul
Given that it’s a fairly low impact change, We’ve got several pip developers +1 on it, Jason is OK with it on the setuptools side, and nobody has spoken out against it I’m going to go ahead and make this change.
--- Donald Stufft PGP: 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA
_______________________________________________ Distutils-SIG maillist - Distutils-SIG@python.org https://mail.python.org/mailman/listinfo/distutils-sig
And done: https://hg.python.org/peps/rev/93db88237edb Will get the libraries updated next. --- Donald Stufft PGP: 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA
Since PEP 440 was formally accepted in August 2014, would it make sense to add a change log to document the amendment of the PEP, for instance in the appendix (maybe with a link to the diff in hg)? -- Olivier
On 18 Dec 2014 20:30, "Olivier Grisel" <olivier.grisel@ensta.org> wrote:
Since PEP 440 was formally accepted in August 2014, would it make sense to add a change log to document the amendment of the PEP, for instance in the appendix (maybe with a link to the diff in hg)?
Yeah, that's a good idea. I'll also include that requirement when I draft the proposed update for PEP 1. Cheers, Nick.
-- Olivier _______________________________________________ Distutils-SIG maillist - Distutils-SIG@python.org https://mail.python.org/mailman/listinfo/distutils-sig
On Dec 17, 2014, at 9:17 PM, Donald Stufft <donald@stufft.io> wrote:
On Dec 17, 2014, at 8:55 PM, Donald Stufft <donald@stufft.io> wrote:
On Dec 16, 2014, at 2:51 PM, Paul Moore <p.f.moore@gmail.com> wrote:
On 16 December 2014 at 17:56, Donald Stufft <donald@stufft.io> wrote:
I’ve had a number of people complain that PEP 440 normalizes a release candidate as 1.0c1 instead of 1.0rc1. Do we want to ammend the PEP to switch the normalization around so that it normalizes 1.0c1 to 1.0rc1? This probably matches what people expect better in general? It wouldn't have any effect on sort order or the like, it would just change which form is preferred.
I'd typically expect to see 1.0rc1 rather than 1.0c1. I don't think it's a crisis either way, but I would mildly prefer it if this change was made. Paul
Given that it’s a fairly low impact change, We’ve got several pip developers +1 on it, Jason is OK with it on the setuptools side, and nobody has spoken out against it I’m going to go ahead and make this change.
--- Donald Stufft PGP: 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA
_______________________________________________ Distutils-SIG maillist - Distutils-SIG@python.org https://mail.python.org/mailman/listinfo/distutils-sig
And done: https://hg.python.org/peps/rev/93db88237edb
Will get the libraries updated next.
setuptools 8.1 is out which has this in it and packaging 14.5 is as well. --- Donald Stufft PGP: 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA
On 18 December 2014 at 11:55, Donald Stufft <donald@stufft.io> wrote:
On Dec 16, 2014, at 2:51 PM, Paul Moore <p.f.moore@gmail.com> wrote:
On 16 December 2014 at 17:56, Donald Stufft <donald@stufft.io> wrote:
I’ve had a number of people complain that PEP 440 normalizes a release candidate as 1.0c1 instead of 1.0rc1. Do we want to ammend the PEP to switch the normalization around so that it normalizes 1.0c1 to 1.0rc1? This probably matches what people expect better in general? It wouldn't have any effect on sort order or the like, it would just change which form is preferred.
I'd typically expect to see 1.0rc1 rather than 1.0c1. I don't think it's a crisis either way, but I would mildly prefer it if this change was made. Paul
Given that it’s a fairly low impact change, We’ve got several pip developers +1 on it, Jason is OK with it on the setuptools side, and nobody has spoken out against it I’m going to go ahead and make this change.
Thanks. I think one key with this particular change is that client tools were already obliged to accept both formats anyway, as normalisation for publication is only a SHOULD, rather than a MUST. Switching the preferred format for publication thus shouldn't break anything on the consumption side. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
participants (4)
-
Donald Stufft -
Nick Coghlan -
Olivier Grisel -
Paul Moore