Howdy -- OK, I'm looking through bdist_wininst.py right now. About all I've fixed so far are typos in comments, and changed it to use 'reinitialize_command()' -- thanks to Bastian for spotting that one (and prodding me into reviewing the code). Some thoughts... these are mostly idle speculation, because I really can't see anything wrong with the code! * should we change ImportError on zlib to DistutilsPlatformError (or something) that generates a friendlier error message... or is this being silly because zlib is absolutely positively always available for Python on Windows? * is "foo-1.0.win32.exe" the right filename for the installer? this is consistent with "dumb" build distributions (simple tarballs and ZIP files) as well as RPMs, so that's a good enough argument for me. * "win32" is hard-coded in a few spots: should that be 'get_platform()' (which now just returns sys.platform)? (I don't remember what the decision on sys.platform for 64-bit Windows was: is it going to return "win32"?) Other than it looks good. I'll see if I can't produce an installer for the Distutils tonight -- that would be, as they say, THE BOMB. ;-) Greg -- Greg Ward - maladjusted nerd gward@python.net http://starship.python.net/~gward/ If it can't be expressed in figures, it is not science--it is opinion.
Some thoughts... these are mostly idle speculation, because I really can't see anything wrong with the code! Hmm, why dont I have my data files in the installer? I can not see them. Is bdist_wininst only for modules because you run the zip tool only in the site-packages dir: changing into 'build/bdist.linux2/wininst/usr/lib/python1.5/site-packages/' zip -rq /home/calvin/projects/linkchecker/linkchecker-1.2.4.win32.zip .
Another thing: the "..." directory browse button of the installer does not work for me under Win98 SE2.
* should we change ImportError on zlib to DistutilsPlatformError (or something) that generates a friendlier error message... or is this being silly because zlib is absolutely positively always available for Python on Windows? If it should be there and it is not then this is an ImportError.
* is "foo-1.0.win32.exe" the right filename for the installer? this is consistent with "dumb" build distributions (simple tarballs and ZIP files) as well as RPMs, so that's a good enough argument for me. Its ok.
Bastian
On 28 June 2000, Bastian Kleineidam said:
Some thoughts... these are mostly idle speculation, because I really can't see anything wrong with the code! Hmm, why dont I have my data files in the installer? I can not see them. Is bdist_wininst only for modules because you run the zip tool only in the site-packages dir: changing into 'build/bdist.linux2/wininst/usr/lib/python1.5/site-packages/' zip -rq /home/calvin/projects/linkchecker/linkchecker-1.2.4.win32.zip .
I think that's a known bug -- there're some comments in the code about it: # XXX hack! Our archive MUST be relative to sys.prefix # XXX What about .install_data, .install_scripts, ...? # [Perhaps require that all installation dirs be under sys.prefix # on Windows? this will be acceptable until we start dealing # with Python applications, at which point we should zip up # the application directory -- and again everything can be # under one dir --GPW] (The first two are Thomas', the third is mine.)
Another thing: the "..." directory browse button of the installer does not work for me under Win98 SE2.
Hmm, I'll have to let the Windows experts deal with that. Thomas' C code (and other project files) is now in CVS, so you can have at it. Greg -- Greg Ward - nerd gward@python.net http://starship.python.net/~gward/ It has just been discovered that research causes cancer in rats.
participants (2)
-
Bastian Kleineidam
-
Greg Ward