setuptools "tests" sprint today
Hi, Like discussed earlier, some people will work today on adding tests to setuptools. The idea is to add human-readable doctests to setuptools a bit like what zc.buildout has. I am planning to create one doctest per setuptools feature, and some general doctest that demonstrates the usage of the tool. (functional tests but preferrably with no os.popen/os.system magic) To synchronize all our work (I doubt we can all get commiter access to svn.python.org today :D ), I have created a launchpad project here: https://launchpad.net/setuptools-test It is a copy of the current setuptools trunk, you can get it with bzr: bzr branch lp:~tziade/setuptools-test/main I suggest we all push changes there then present that work for review to Phillip, Let's meet in #distutils today ! Regards Tarek -- Tarek Ziadé | Association AfPy | www.afpy.org Blog FR | http://programmation-python.org Blog EN | http://tarekziade.wordpress.com/
On Sun, Jun 22, 2008 at 11:25 AM, Tarek Ziadé
Hi,
Like discussed earlier, some people will work today on adding tests to setuptools.
The idea is to add human-readable doctests to setuptools a bit like what zc.buildout has.
I am planning to create one doctest per setuptools feature, and some general doctest that demonstrates the usage of the tool. (functional tests but preferrably with no os.popen/os.system magic)
Heres a first quick draft for 'develop': http://paste.plone.org/22122 It uses a bit of magic to simulate a command line usage like in zc.buildout, to avoid having to write too much test fixture in the doctests. It prints out all infos written by setuptools to distutils.log.info (so to stdout as well) I guess this is enough to write functional tests for all commands, I am going to write similar doctest for all commands, Phillip, is this what you had in mind ? Regards Tarek
Tarek Ziadé wrote:
Hi,
Like discussed earlier, some people will work today on adding tests to setuptools.
The idea is to add human-readable doctests to setuptools a bit like what zc.buildout has.
I am planning to create one doctest per setuptools feature, and some general doctest that demonstrates the usage of the tool. (functional tests but preferrably with no os.popen/os.system magic)
To synchronize all our work (I doubt we can all get commiter access to svn.python.org http://svn.python.org today :D ), I have created a launchpad project here: https://launchpad.net/setuptools-test
It is a copy of the current setuptools trunk, you can get it with bzr:
bzr branch lp:~tziade/setuptools-test/main Since we created a group for setuptools, the new link to the branch is:
bzr branch lp:~setuptools/setuptools-test/main -- Chris Galvan
I suggest we all push changes there then present that work for review to Phillip,
Let's meet in #distutils today !
Regards Tarek
-- Tarek Ziadé | Association AfPy | www.afpy.org http://www.afpy.org Blog FR | http://programmation-python.org Blog EN | http://tarekziade.wordpress.com/ ------------------------------------------------------------------------
_______________________________________________ Distutils-SIG maillist - Distutils-SIG@python.org http://mail.python.org/mailman/listinfo/distutils-sig
Hello, I was hoping to have another sprint this weekend to continue our work on adding tests to setuptools, but we haven't received any feedback on the work we've done so far yet. We would like to get some feedback from others, especially Phillip, on the work we've done so far before continuing to work on the tests :) For iteration's sake, here is the link to the launchpad project being used: https://code.launchpad.net/~setuptools/setuptools-test/main -- Chris Galvan Tarek Ziadé wrote:
Hi,
Like discussed earlier, some people will work today on adding tests to setuptools.
The idea is to add human-readable doctests to setuptools a bit like what zc.buildout has.
I am planning to create one doctest per setuptools feature, and some general doctest that demonstrates the usage of the tool. (functional tests but preferrably with no os.popen/os.system magic)
To synchronize all our work (I doubt we can all get commiter access to svn.python.org http://svn.python.org today :D ), I have created a launchpad project here: https://launchpad.net/setuptools-test
It is a copy of the current setuptools trunk, you can get it with bzr:
bzr branch lp:~tziade/setuptools-test/main
I suggest we all push changes there then present that work for review to Phillip,
Let's meet in #distutils today !
Regards Tarek
-- Tarek Ziadé | Association AfPy | www.afpy.org http://www.afpy.org Blog FR | http://programmation-python.org Blog EN | http://tarekziade.wordpress.com/ ------------------------------------------------------------------------
_______________________________________________ Distutils-SIG maillist - Distutils-SIG@python.org http://mail.python.org/mailman/listinfo/distutils-sig
On Thu, Jun 26, 2008 at 01:51:09PM -0500, Chris Galvan wrote:
I was hoping to have another sprint this weekend to continue our work on adding tests to setuptools, but we haven't received any feedback on the work we've done so far yet. We would like to get some feedback from others, especially Phillip, on the work we've done so far before continuing to work on the tests :)
The knowledge that someone is writing tests for a very important piece of infrastructure that I plan to use more and more heavily in the future filled me with joy.
It is a copy of the current setuptools trunk, you can get it with bzr:
bzr branch lp:~tziade/setuptools-test/main
I get bzr: ERROR: Not a branch: "http://bazaar.launchpad.net/~tziade/setuptools-test/main/". but that's probably because it's bzr 1.3.1 from Ubuntu Hardy. I'll try with bzr 1.5. Marius Gedminas -- I saw `cout' being shifted "Hello world" times to the left and stopped right there!! -- Steve Gonedes
On Thu, Jun 26, 2008 at 11:45:12PM +0300, Marius Gedminas wrote:
It is a copy of the current setuptools trunk, you can get it with bzr:
bzr branch lp:~tziade/setuptools-test/main
I get
bzr: ERROR: Not a branch: "http://bazaar.launchpad.net/~tziade/setuptools-test/main/".
but that's probably because it's bzr 1.3.1 from Ubuntu Hardy. I'll try with bzr 1.5.
Same error with bzr 1.5, but I finally found the right URL: bzr branch lp:~setuptools/setuptools-test/main Now, how do I run the test suite? I see no scripts with suggestive names (such as test.py or runtests.py), setup.py test says there's no such command, nosetests aborts with a mysterious TypeError deep in its internals. Marius Gedminas -- Perl is not a programming language, it's a natural language that computers understand. Better than people, for the most part. -- Steve Simmons
On Thu, Jun 26, 2008 at 11:54:16PM +0300, Marius Gedminas wrote:
Same error with bzr 1.5, but I finally found the right URL:
bzr branch lp:~setuptools/setuptools-test/main
Now, how do I run the test suite? I see no scripts with suggestive names (such as test.py or runtests.py), setup.py test says there's no such command, nosetests aborts with a mysterious TypeError deep in its internals.
I tried ./setup.py test again, and it worked. Apparently it needs python-setuptools installed in my system Python, which I got as a side effect of apt-get installing python-nose. All 55 tests pass here. Marius Gedminas -- (mental note: stop installing red hat. everytime i do so, it takes ages to fix my system again.) -- from the sig of Martin H�gman
On Thu, Jun 26, 2008 at 10:57 PM, Marius Gedminas
On Thu, Jun 26, 2008 at 11:54:16PM +0300, Marius Gedminas wrote:
Same error with bzr 1.5, but I finally found the right URL:
bzr branch lp:~setuptools/setuptools-test/main
Now, how do I run the test suite? I see no scripts with suggestive names (such as test.py or runtests.py), setup.py test says there's no such command, nosetests aborts with a mysterious TypeError deep in its internals.
I tried ./setup.py test again, and it worked. Apparently it needs python-setuptools installed in my system Python, which I got as a side effect of apt-get installing python-nose.
A yes, there's a setup_requires metadata in setup.py that needs to be uncommented for tests to work. I wonder if this could not be changed to a test_requires section, I'll try
All 55 tests pass here.
Cool, thanks for the feedback
Marius Gedminas -- (mental note: stop installing red hat. everytime i do so, it takes ages to fix my system again.) -- from the sig of Martin Högman
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFIZAKikVdEXeem148RAgT9AJ4qHcdh0nr8fAJBLrLKXimdSAdJ/gCdEOBg fdi27NSHc+FcplzHMDABFlo= =Frj/ -----END PGP SIGNATURE-----
_______________________________________________ Distutils-SIG maillist - Distutils-SIG@python.org http://mail.python.org/mailman/listinfo/distutils-sig
-- Tarek Ziadé | Association AfPy | www.afpy.org Blog FR | http://programmation-python.org Blog EN | http://tarekziade.wordpress.com/
Marius Gedminas wrote:
The knowledge that someone is writing tests for a very important piece of infrastructure that I plan to use more and more heavily in the future filled me with joy.
I'm glad you feel that way :)
I get
bzr: ERROR: Not a branch: "http://bazaar.launchpad.net/~tziade/setuptools-test/main/".
but that's probably because it's bzr 1.3.1 from Ubuntu Hardy. I'll try with bzr 1.5.
Marius Gedminas
You are getting that error because that link is out-dated. The original branch was under Tarek's launchpad directory, but we ended up moving it to a setuptools group so that it would be easier to give people access to the branch. Here is the link to the current branch: bzr branch lp:~setuptools/setuptools-test/main Let me know if you have any problems with that link :) -- Chris Galvan
On Jun 26, 2008, at 11:51 AM, Chris Galvan wrote:
I was hoping to have another sprint this weekend to continue our work on adding tests to setuptools, but we haven't received any feedback on the work we've done so far yet. We would like to get some feedback from others, especially Phillip, on the work we've done so far before continuing to work on the tests :)
Here's some feedback: Way to go!!! I'm so glad that you are writing automated tests for setuptools. Let's integrate your patches into the trunk as soon as possible (I guess that is blocked on PJE doing so or granting commit access to someone else who can do so), and let's write more tests, and let's set up a buildbot to automatically run all the tests on every checkin. I could contribute a buildmaster and administration thereof. Regards, Zooko
On Thu, Jun 26, 2008 at 8:51 PM, Chris Galvan
Hello,
I was hoping to have another sprint this weekend to continue our work on adding tests to setuptools, but we haven't received any feedback on the work we've done so far yet. We would like to get some feedback from others, especially Phillip, on the work we've done so far before continuing to work on the tests :)
+1 I was hoping to have some feedback as well on this topic by Phillip, since he asked for tests in setuptools. I hope we didn't work for nothing :D Tarek
Dear PJE: Thank you so much for inventing setuptools and for bringing it to its current level of maturity. It seems that you don't have time right now to be the sole maintainer of setuptools. Opening up a codebase to commits from multiple people is always risky, but once a project is big and successful enough, multiple maintainers are often needed to make sufficiently fast progress. Fortuately, there is a good way to ameliorate the risks and to help multiple programmers coordinate with one another: unit tests. Also fortunately, Tarek Ziadé and Chris Galvan have spent some time recently writing tests for setuptools. Please give those two folks commit privileges to the setuptools SVN repository so that they will be maximally empowered and encouraged to continue that work! We -- the community of people who care enough about setuptools to spend time improving it -- will make an effort to maintain setuptools's high level of quality, both by automated testing, by code review, and by manual testing in real-world deployments. Thanks, Your user, Zooko
participants (4)
-
Chris Galvan -
Marius Gedminas -
Tarek Ziadé -
zooko