Hi all,
a bdist_inno command to generate an installer with Inno Setup has been discussed previously but I don't know whether anybody has done anything about it. Has anything changed in this regard? Has anybody started to write it?
I'll start writing it myself, otherwise. I don't know how general it will be, though. All I really need at the moment is an implementation that's good enough for my needs.
Bernhard
Bernhard Herzog wrote:
Hi all,
a bdist_inno command to generate an installer with Inno Setup has been discussed previously but I don't know whether anybody has done anything about it. Has anything changed in this regard? Has anybody started to write it?
I'll start writing it myself, otherwise. I don't know how general it will be, though. All I really need at the moment is an implementation that's good enough for my needs.
I looked into writing one, but was on vacation for the last three weeks and didn't get around to it.
I think the bdist_rpm command should go a long way as template for the bdist_inno command.
On Mon, Sep 10, 2001 at 10:21:56PM +0200, M.-A. Lemburg wrote:
I think the bdist_rpm command should go a long way as template for the bdist_inno command.
Also note patch #415226 on SourceForge, which creates a new base class for binary packaging. I'd like comments on whether this patch is a good idea.
--amk
Andrew Kuchling akuchlin@mems-exchange.org writes:
On Mon, Sep 10, 2001 at 10:21:56PM +0200, M.-A. Lemburg wrote:
I think the bdist_rpm command should go a long way as template for the bdist_inno command.
Also note patch #415226 on SourceForge, which creates a new base class for binary packaging. I'd like comments on whether this patch is a good idea.
In principle it's a good idea, I think. I'm not so sure about the patch as it is, though.
The script parameters (preinstall, postinstall, etc.) are probably unix or even RPM specific. Their documentation explicitly says they're "Bourne shell code".
It's also not clear whether their values are filenames (as in bdist_rpm) or the actual code. The get_script method allows both (and even a list of strings) and the ensure_script method appears to but doesn't do it correctly (it tests for string first which will always be true even if it's a filename; the correct implementation would probably just check for string).
The run method doesn't seem to do any actual work and even hinders derived classes in just extending it. ISTM that derived classes will have to overwrite this method (in its current implementation) completely.
Last not least, I agree with Martin's comment in the patch tracker that the patch should also modify existing bdist commands.
Bernhard
"M.-A. Lemburg" mal@lemburg.com writes:
Bernhard Herzog wrote:
Hi all,
a bdist_inno command to generate an installer with Inno Setup has been discussed previously but I don't know whether anybody has done anything about it. Has anything changed in this regard? Has anybody started to write it?
I'll start writing it myself, otherwise. I don't know how general it will be, though. All I really need at the moment is an implementation that's good enough for my needs.
I looked into writing one, but was on vacation for the last three weeks and didn't get around to it.
Well, I've written one for our project in the meantime. I've tried to separate the generic bdist_inno code from our application specific code so I can make it available separately. The current version, just put online, is: ftp://intevation.de/users/bh/bdist_inno-0.1.py
It's a bit kludgy and unfinished but it works for us. One reason it's kludgy is that it's for an application and not just modules.
I think the bdist_rpm command should go a long way as template for the bdist_inno command.
I borrowed some ideas from it, at least. :)
Bernhard
participants (3)
-
Andrew Kuchling -
Bernhard Herzog -
M.-A. Lemburg