bdist_wininst updated in CVS repository
I just checked in a new version of bdist_wininst. Changes: distutils/command/bdist_wininst.py: - the windows installer is again able to compile after installing the files. Note: The default has changed, the packager has to give --no-target-compile/--no-target-optimize to NOT compile on the target system. (Another note: install_lib's --compile --optimize options have the same semantics to switch off the compilation. Shouldn't the names change?) - All references to specific python versions are gone. - A small bug: raise DistutilsPlatformError ("...") instead of raise DistutilsPlatformError, ("...") - When bdist_wininst creates an installer for one specific python version, this is reflected in the name: Distutils-0.9.2.win32-py15.exe instead of Distutils-0.9.2.win32.exe - bdist_wininst, when run as script, reads the wininst.exe file and rewrites itself. Previously this was done by hand. misc/install.c - All the changes needed for compilation - Deleted a lot of debug/dead code Thomas Heller
On Thu, Sep 07, 2000 at 06:06:16PM +0200, Thomas Heller wrote:
- A small bug: raise DistutilsPlatformError ("...") instead of raise DistutilsPlatformError, ("...")
Are you sure that is in fact a bug? If DistutilsPlatformError is a class-based exception, the first form is quite legal. --amk
"AMK" == Andrew Kuchling <akuchlin@mems-exchange.org> writes:
AMK> On Thu, Sep 07, 2000 at 06:06:16PM +0200, Thomas Heller wrote:
- A small bug: raise DistutilsPlatformError ("...") instead of raise DistutilsPlatformError, ("...")
AMK> Are you sure that is in fact a bug? If DistutilsPlatformError AMK> is a class-based exception, the first form is quite legal. Except that the space between DisutilsPlatformError and the open paren is bad Python style. Jeremy
Andrew Kuchling writes:
On Thu, Sep 07, 2000 at 06:06:16PM +0200, Thomas Heller wrote:
- A small bug: raise DistutilsPlatformError ("...") instead of raise DistutilsPlatformError, ("...")
Are you sure that is in fact a bug? If DistutilsPlatformError is a class-based exception, the first form is quite legal.
This is a style issue. The first form is normally recommended for exceptions that are always classes. But the spaces between the name of something callable and the opening parenthesis of the parameter list should go -- that's in Guido's style "essay". -Fred -- Fred L. Drake, Jr. <fdrake at beopen.com> BeOpen PythonLabs Team Member
participants (4)
-
Andrew Kuchling
-
Fred L. Drake, Jr.
-
Jeremy Hylton
-
Thomas Heller