This seems odd to me... When I build a source distribution with python setup.py sdist, my MANIFEST.in file is not included in the resulting archive. This seems wrong, as without the MANIFEST.in, I cannot rebuild the distribution. I would assume that building a sdist should create save everything needed to rebuild the package, its sdist, etc etc, from scratch. Another thought - a "reallyclean" command would be nice (deletes all intermediate and generated files - essentially all of the "build" and "dist" directories, at least... Thanks, Paul Moore
Paul Moore wrote:
This seems odd to me...
When I build a source distribution with python setup.py sdist, my MANIFEST.in file is not included in the resulting archive. This seems wrong, as without the MANIFEST.in, I cannot rebuild the distribution.
Ok, this is easy to change. The attached patch adds the template file (MANIFEST.in) to MANIFEST if the template file is used and the no-defaults option was not given. file: sdist.patch Kind regards Rene Liebscher
It seems I forgot to attach the patch. file: sdist.patch Kind regards Rene Liebscher diff -BurN --exclude=*.pyc --minimal distutils.orig/distutils/command/sdist.py distutils.patched2/distutils/command/sdist.py --- distutils.orig/distutils/command/sdist.py Mon Oct 16 11:37:41 2000 +++ distutils.patched2/distutils/command/sdist.py Mon Oct 30 13:13:36 2000 @@ -244,6 +244,8 @@ # Read manifest template if it exists if template_exists: self.read_template() + if self.use_defaults: # don't forget MANIFEST.in + self.filelist.append(self.template) # Prune away any directories that don't belong in the source # distribution
I never saw any reply to this, so... On Fri, Oct 27, 2000 at 10:02:46PM +0100, Paul Moore wrote:
This seems odd to me...
When I build a source distribution with python setup.py sdist, my MANIFEST.in file is not included in the resulting archive. This seems wrong, as without the MANIFEST.in, I cannot rebuild the distribution.
I would assume that building a sdist should create save everything needed to rebuild the package, its sdist, etc etc, from scratch.
I don't think sdist will automatically add any files to the manifest for you, so you have to explicitly add an include line for it. For example, PyXML's MANIFEST.in starts with: include ANNOUNCE include CREDITS include LICENCE include MANIFEST include MANIFEST.in include README* include TODO include setup.py ... (I believe those could all be collapsed into one line, but you get the idea.)
Another thought - a "reallyclean" command would be nice (deletes all intermediate and generated files - essentially all of the "build" and "dist" directories, at least...
Should be easy to write... up to Greg to decide if it's worth adding. --amk
Hi all, >I don't think sdist will automatically add any files to the manifest for you, >so you have to explicitly add an include line for it. For example, PyXML's MANIFEST.in starts with: Quoting from sdist.py standard files added are - README or README.txt - setup.py - test/test*.py - all pure Python modules mentioned in setup script - all C sources listed as part of extensions or C libraries in the setup script (doesn't catch C headers!) >>Another thought - a "reallyclean" command would be nice (deletes all >>intermediate and generated files - essentially all of the "build" and "dist" >>directories, at least... python setup.py clean --all deletes the 'build' directory and all temporary 'dist' files. It does not clean generated Distributions packages in 'dist'. Bastian
participants (4)
-
Andrew Kuchling -
Bastian Kleineidam -
Paul Moore -
Rene Liebscher