Better error reporting
There are places where setuptools exceptions sometimes lack important information. For example, in PackageIndex.open_url, there is: def open_url(self, url): if url.startswith('file:'): return local_open(url) try: return open_with_auth(url) except urllib2.HTTPError, v: return v except urllib2.URLError, v: raise DistutilsError("Download error: %s" % v.reason) Getting a download error without knowing what the error is for is rather frustrating. :) IMO, this should be: def open_url(self, url): if url.startswith('file:'): return local_open(url) try: return open_with_auth(url) except urllib2.HTTPError, v: return v except urllib2.URLError, v: raise DistutilsError("Download error for %r: %s" % (url, v.reason)) Phillip, would you like me to go ahead and make minor changes like this? Or would you rather make them yourself? Jim -- Jim Fulton mailto:jim@zope.com Python Powered! CTO (540) 361-1714 http://www.python.org Zope Corporation http://www.zope.com http://www.zope.org
At 11:09 AM 2/12/2007 -0500, Jim Fulton wrote:
Phillip, would you like me to go ahead and make minor changes like this? Or would you rather make them yourself?
Just let me know about them, so I won't be taken by surprise when I can't commit due to being out of date. ;)
participants (2)
-
Jim Fulton
-
Phillip J. Eby