Hi, Sorry for late replaying. Sphinx now has the option "smartquotes_excludes" in conf.py that disable smartquotes directly. This option might be better, because this enables more detailed and straightforward configuration. Please refer to the documentation [1]. [1] http://www.sphinx-doc.org/ja/1.7/config.html#confval-smartquotes_excludes Regards, cocoatomo On Sun, 16 Sep 2018 at 06:13, Julien Palard via Doc-SIG <doc-sig@python.org> wrote:

Hi Adrian,

...

here in our generated html the quotes not only are transformed into Chinese quotes automatically

I created a PR to disable smart quotes for zh-tw [1], can you please try it?

[1] https://github.com/python/cpython/pull/9337 <https://github.com/python/cpython/pull/9337>

Bests, -- Julien Palard https://mdk.fr

_______________________________________________ Doc-SIG maillist - Doc-SIG@python.org https://mail.python.org/mailman/listinfo/doc-sig

-- class Cocoatomo: name = 'cocoatomo' email_address = 'cocoatomo77@gmail.com' twitter_id = '@cocoatomo'

Hi Adrian, I like this approach too, I can modify my PR, or would you open a PR with your test Adrian? I'll appreciate if you add 'fr' in the exclude list, we just got bitten by this issue too. -- Julien Palard https://mdk.fr ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Monday, September 17, 2018 9:37 AM, Adrian Liaw <adrianliaw2000@gmail.com> wrote:

Hi Julien,

It works perfectly, thank you so much for creating the PR!

Hi cocoatomo,

...

Sphinx now has the option "smartquotes_excludes" in conf.py that disablesmartquotes directly. This option might be better, because this enables more detailed and straightforward configuration.

Thanks for the information, I've tried adding a line of smartquotes_excludes = {'languages': ['ja', 'zh_TW'], 'builders': ['man', 'text']} in the conf.py of my local CPython clone (and removing the docutils.conf) and it works perfectly. Maybe it's a good idea to adapt this approach.

Best Regards, -- Wey-Han "Adrian" Liaw (@adrianliaw2000) https://linkedin.com/in/adrianliaw https://github.com/adrianliaw

Hi, I just submitted a PR: https://github.com/python/cpython/pull/9423 that includes the patch, can you please try it and see if it works? Japanese team, can you also please try it out? Also, should we add skip news and skip issue labels to this PR? I'm not sure if I'm missing anything in my PR since this is my very first contribution to the CPython repo, will appreciate if anyone finds any thing missing that I should do! Best, On Tue, 18 Sep 2018 at 10:20 Adrian Liaw <adrianliaw2000@gmail.com> wrote:

Hi Julien,

No problem, I'll do that.

Best,

On Mon, 17 Sep 2018 at 22:56 Julien Palard <julien@palard.fr> wrote:

...

Hi Adrian,

I like this approach too, I can modify my PR, or would you open a PR with your test Adrian? I'll appreciate if you add 'fr' in the exclude list, we just got bitten by this issue too.

-- Julien Palard https://mdk.fr

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Monday, September 17, 2018 9:37 AM, Adrian Liaw < adrianliaw2000@gmail.com> wrote:

Hi Julien,

It works perfectly, thank you so much for creating the PR!

Hi cocoatomo,

...

Sphinx now has the option "smartquotes_excludes" in conf.py that disable smartquotes directly. This option might be better, because this enables more detailed and straightforward configuration.

Thanks for the information, I've tried adding a line of smartquotes_excludes = {'languages': ['ja', 'zh_TW'], 'builders': ['man', 'text']} in the conf.py of my local CPython clone (and removing the docutils.conf) and it works perfectly. Maybe it's a good idea to adapt this approach.

Best Regards, -- Wey-Han "Adrian" Liaw (@adrianliaw2000) https://linkedin.com/in/adrianliaw https://github.com/adrianliaw

-- Wey-Han "Adrian" Liaw (@adrianliaw2000) https://linkedin.com/in/adrianliaw https://github.com/adrianliaw

-- Wey-Han "Adrian" Liaw (@adrianliaw2000) https://linkedin.com/in/adrianliaw https://github.com/adrianliaw