[issue26120] pydoc: move __future__ imports out of the DATA block
Irit Katriel <iritkatriel@gmail.com> added the comment:
Yet one bug: PR 30888 only changed the text output. But there is also the html output generator.
I'm not sure - if I revert the change like this: if isinstance(getattr(obj, name, None), __future__._Feature): - return False + pass # return False then test_html_doc fails: ====================================================================== FAIL: test_html_doc (test.test_pydoc.PydocDocTest.test_html_doc) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/iritkatriel/src/cpython/Lib/test/test_pydoc.py", line 414, in test_html_doc self.assertEqual(text_lines, expected_lines) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AssertionError: Lists differ: ['tes[1392 chars]t]', "print_function = _Feature((2, 6, 0, 'alp[156 chars]ody'] != ['tes[1392 chars]t]', 'type_union1 = typing.Union[int, str]', '[72 chars]ody'] First differing element 55: "print_function = _Feature((2, 6, 0, 'alp[36 chars]576)" 'type_union1 = typing.Union[int, str]' First list contains 1 additional elements. First extra element 61: 'Nobody' ['test.pydoc_mod (version 1.2.3.4)', 'This is a test module for test_pydoc', 'Modules', 'types', 'typing', 'Classes', 'builtins.object', 'A', 'B', 'C', 'class A(builtins.object)', 'Hello and goodbye', 'Methods defined here:', '__init__()', 'Wow, I have no function!', 'Data descriptors defined here:', '__dict__', 'dictionary for instance variables (if defined)', '__weakref__', 'list of weak references to the object (if defined)', 'class B(builtins.object)', 'Data descriptors defined here:', '__dict__', 'dictionary for instance variables (if defined)', '__weakref__', 'list of weak references to the object (if defined)', 'Data and other attributes defined here:', "NO_MEANING = 'eggs'", "__annotations__ = {'NO_MEANING': <class 'str'>}", 'class C(builtins.object)', 'Methods defined here:', 'get_answer(self)', 'Return say_no()', 'is_it_true(self)', 'Return self.get_answer()', 'say_no(self)', 'Class methods defined here:', '__class_getitem__(item) from builtins.type', 'Data descriptors defined here:', '__dict__', 'dictionary for instance variables (if defined)', '__weakref__', 'list of weak references to the object (if defined)', 'Functions', 'doc_func()', "This function solves all of the world's problems:", 'hunger', 'lack of Python', 'war', 'nodoc_func()', 'Data', "__xyz__ = 'X, Y and Z'", 'c_alias = test.pydoc_mod.C[int]', 'list_alias1 = typing.List[int]', 'list_alias2 = list[int]', - "print_function = _Feature((2, 6, 0, 'alpha', 2), (3, 0, 0, 'alpha', 0), " - '1048576)', 'type_union1 = typing.Union[int, str]', 'type_union2 = int | str', 'Author', 'Benjamin Peterson', 'Credits', 'Nobody'] ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue26120> _______________________________________
participants (1)
-
Irit Katriel