Hugo van Kemenade added the comment: re: https://bugs.python.org/issue45618#msg416017 Maciej Olko, please could you update these PRs to keep the Sphinx version the same and only pin Jinja2 to match? 3.7: https://github.com/python/cpython/pull/32109 3.8: https://github.com/python/cpython/pull/32111 I guess update them to use this bpo too. Thanks! ---------- title: Bump Sphinx to fix docs build -> Bump Sphinx or pin Jinja2 to fix docs build _______________________________________ Python tracker https://bugs.python.org/issue47138 _______________________________________

Change by Maciej Olko : ---------- pull_requests: +30232 pull_request: https://github.com/python/cpython/pull/32109 _______________________________________ Python tracker https://bugs.python.org/issue47138 _______________________________________

Ned Deily added the comment: Thank you both for addressing this. The main reason for minimizing changes to the docs build chain for brances in bugfix or security-fix-only phases is that many distributors of Python also release the Python docs as a package and they do not necessarily rely on using our fairly-recent venv step in the Docs Makefile. In particular, they want to use the versions of Sphinx et al that they release as packages. If we change the required versions for these mid-stream, they not only have to update the docs themselves but have to go through the process of updating the other packages (like Sphinx) which may have other consequences. This can also impact our own on-line doc building process. (Version updates for a new Python feature release prior to its entering beta phase are not a problem.) So it is best to do the minimal amount of version updating for releases in the field, preferably none (as in pinning existing versions). In that spirit, we should also just pin the Jinja2 version for 3.10 and 3.9. ---------- nosy: +ned.deily _______________________________________ Python tracker https://bugs.python.org/issue47138 _______________________________________

Change by Hugo van Kemenade : ---------- pull_requests: +30235 pull_request: https://github.com/python/cpython/pull/32154 _______________________________________ Python tracker https://bugs.python.org/issue47138 _______________________________________

Ned Deily added the comment: New changeset 25f00bfb264a3197ac91c41cdec15036fd8401f1 by m-aciek in branch '3.7': bpo-47138: Fix documentation build by pinning Jinja version to 3.0.3 (GH-32111) https://github.com/python/cpython/commit/25f00bfb264a3197ac91c41cdec15036fd8... ---------- _______________________________________ Python tracker https://bugs.python.org/issue47138 _______________________________________

Ned Deily added the comment: New changeset 25c40bd994aa0da75283c5efdd71ba26c734b67e by Hugo van Kemenade in branch '3.9': bpo-47138: Fix documentation build by pinning Jinja version to 3.0.3 (GH-32153) https://github.com/python/cpython/commit/25c40bd994aa0da75283c5efdd71ba26c73... ---------- _______________________________________ Python tracker https://bugs.python.org/issue47138 _______________________________________

Change by Steve Dower : ---------- nosy: +steve.dower nosy_count: 4.0 -> 5.0 pull_requests: +30239 status: pending -> open pull_request: https://github.com/python/cpython/pull/32161 _______________________________________ Python tracker https://bugs.python.org/issue47138 _______________________________________

Change by Steve Dower : ---------- pull_requests: +30241 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/32163 _______________________________________ Python tracker https://bugs.python.org/issue47138 _______________________________________

Change by miss-islington : ---------- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +30245 pull_request: https://github.com/python/cpython/pull/32167 _______________________________________ Python tracker https://bugs.python.org/issue47138 _______________________________________

Change by miss-islington : ---------- pull_requests: +30247 pull_request: https://github.com/python/cpython/pull/32169 _______________________________________ Python tracker https://bugs.python.org/issue47138 _______________________________________

Change by Steve Dower : ---------- pull_requests: +30259 pull_request: https://github.com/python/cpython/pull/32182 _______________________________________ Python tracker https://bugs.python.org/issue47138 _______________________________________

Change by Steve Dower : ---------- pull_requests: +30260 pull_request: https://github.com/python/cpython/pull/32183 _______________________________________ Python tracker https://bugs.python.org/issue47138 _______________________________________