Change by Maciej Olko : ---------- versions: -Python 3.11, Python 3.6, Python 3.7, Python 3.8, Python 3.9 _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Maciej Olko added the comment: The pin can be removed after bumping Sphinx to at least 3.5.4, which introduced upper limit for docutils version. https://github.com/sphinx-doc/sphinx/commit/9263eea38379822e053c67ad1d17036d... ---------- _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Change by Ned Deily : ---------- nosy: +lukasz.langa, mdk, pablogsal priority: normal -> release blocker versions: +Python 3.9 _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Ned Deily added the comment: New changeset bcee6aa31550cfecdc3acecbd0e4447bb0051887 by m-aciek in branch 'main': bpo-45618: Fix documentation build by pinning Docutils version to 0.17.1 (GH-29230) https://github.com/python/cpython/commit/bcee6aa31550cfecdc3acecbd0e4447bb00... ---------- nosy: +ned.deily _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Change by Ned Deily : ---------- pull_requests: +27504 pull_request: https://github.com/python/cpython/pull/29241 _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Ned Deily added the comment: New changeset 30c1f18ee62cef301e18488b80b4d329290f7b95 by Ned Deily in branch '3.9': [3.9] bpo-45618: Fix documentation build by pinning Docutils version to 0.17.1 (GH-29230) (GH-29241) https://github.com/python/cpython/commit/30c1f18ee62cef301e18488b80b4d329290... ---------- _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Ned Deily added the comment: All of the open branches are affected by this since we also have to build documentation for security-fix-only branches when releases. PRs for 3.7 and 3.6 forthcoming. ---------- versions: +Python 3.6, Python 3.7, Python 3.8 _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Maciej Olko added the comment: It occurs that the documentation builds without warnings on most recent Sphinx -- version 4.2.0. Probably we should bump the version in 3.11, 3.10 and 3.9 to 4.2.0. That would enable us to remove the pin on docutils. ---------- _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Change by Maciej Olko : ---------- pull_requests: +27520 pull_request: https://github.com/python/cpython/pull/29256 _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

miss-islington added the comment: New changeset 14a4fce457033412278ca9a056787db424310dc3 by m-aciek in branch 'main': bpo-45618: Update Sphinx version used to build the documentation to 4.2.0 (GH-29256) https://github.com/python/cpython/commit/14a4fce457033412278ca9a056787db4243... ---------- _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Change by Ned Deily : ---------- pull_requests: +29606 pull_request: https://github.com/python/cpython/pull/31476 _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Maciej Olko added the comment: After the Jinja version 3.1.0 release today [1], documentation builds fail for all stable branches. Sphinx in versions pinned on those branches fails with ImportError. [2] Backporting 14a4fce457033412278ca9a056787db424310dc3 to 3.10 and 3.9 fixes the problem for them (build is successful with 4.2.0). For 3.8 and 3.7 pinning down Jinja is required (docs don't build smoothly with 4.2.0 for those branches). Could some core developer help with the backports? I am starting to work on PRs with pins for 3.8 and 3.7. [1] https://jinja.palletsprojects.com/en/3.1.x/changes/#version-3-1-0 [2] % sphinx-build --version Traceback (most recent call last): File "…/cpython/Doc/./venv/bin/sphinx-build", line 5, in <module> from sphinx.cmd.build import main File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/cmd/build.py", line 25, in <module> from sphinx.application import Sphinx File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/application.py", line 42, in <module> from sphinx.registry import SphinxComponentRegistry File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/registry.py", line 24, in <module> from sphinx.builders import Builder File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/builders/__init__.py", line 26, in <module> from sphinx.util import import_object, logging, rst, progress_message, status_iterator File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/util/rst.py", line 22, in <module> from jinja2 import environmentfilter ImportError: cannot import name 'environmentfilter' from 'jinja2' (…/cpython/Doc/venv/lib/python3.9/site-packages/jinja2/__init__.py) ---------- resolution: fixed -> status: closed -> open versions: -Python 3.11, Python 3.6 _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Change by Maciej Olko : ---------- pull_requests: +30194 pull_request: https://github.com/python/cpython/pull/32111 _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Change by miss-islington : ---------- pull_requests: +30200 pull_request: https://github.com/python/cpython/pull/32120 _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Change by Ned Deily : ---------- pull_requests: -30200 _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Maciej Olko added the comment:

This really should be handled in a new issue since the original fixes for all affected releases are already in the field.

Sorry, I got suggested too much with expected fix which is common for both of those issues. Shall I create a new issue?

Moreover, we should be a bit careful about bumping the required Sphinx version for older releases as this has caused problems for downstream distributors of Python in the past. Can't we just pin the Jinja2 version for current releases?

Didn't know about the problems for distributors. Definitely just pinning Jinja2 is enough. ---------- _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Change by Ned Deily : ---------- pull_requests: -30186 _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________

Change by Ned Deily : ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker https://bugs.python.org/issue45618 _______________________________________