[issue45790] Inaccurate phrasing in extending/newtypes_tutorial
New submission from Rodrigo Tobar <rtobarc@gmail.com>: In `extending/newtypes_tutorial.rst` the following phrase appears: "[...], containing a pointer to a type object and a reference count (these can be accessed using the macros :c:macro:`Py_REFCNT` and c:macro:`Py_TYPE` respectively)." I believe it should read "using the macros :c:macro:`Py_TYPE` and c:macro:`Py_REFCNT` respectively" to follow the same order in which the fields are described. I'll put forward a patch. It seems this phrase goes way back a few python versions, but I'm tagging 3.11 here only. ---------- assignee: docs@python components: Documentation messages: 406185 nosy: docs@python, rtobar2 priority: normal severity: normal status: open title: Inaccurate phrasing in extending/newtypes_tutorial versions: Python 3.11 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45790> _______________________________________
Change by Rodrigo <rtobar@icrar.org>: ---------- keywords: +patch nosy: +rtobar nosy_count: 2.0 -> 3.0 pull_requests: +27779 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29529 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45790> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +30381 pull_request: https://github.com/python/cpython/pull/32320 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45790> _______________________________________
Jelle Zijlstra <jelle.zijlstra@gmail.com> added the comment: New changeset b275267aa7d44ec90fa435c9cb1610c549da745a by rtobar in branch 'main': bpo-45790: List macros in same order in which fields are described (GH-29529) https://github.com/python/cpython/commit/b275267aa7d44ec90fa435c9cb1610c549d... ---------- nosy: +JelleZijlstra _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45790> _______________________________________
Change by Jelle Zijlstra <jelle.zijlstra@gmail.com>: ---------- pull_requests: +30382 pull_request: https://github.com/python/cpython/pull/32321 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45790> _______________________________________
Jelle Zijlstra <jelle.zijlstra@gmail.com> added the comment: Thanks for noticing and fixing! ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45790> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset f4e711bb49881deb1f07a685878646cd5cdee50f by Miss Islington (bot) in branch '3.10': bpo-45790: List macros in same order in which fields are described (GH-29529) https://github.com/python/cpython/commit/f4e711bb49881deb1f07a685878646cd5cd... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45790> _______________________________________
Jelle Zijlstra <jelle.zijlstra@gmail.com> added the comment: New changeset d1fb16ae286795abe3e9da86332c891b4b18826f by Jelle Zijlstra in branch '3.9': [3.9] bpo-45790: List macros in same order in which fields are described (GH-29529) (GH-32321) https://github.com/python/cpython/commit/d1fb16ae286795abe3e9da86332c891b4b1... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45790> _______________________________________
participants (4)
-
Jelle Zijlstra -
miss-islington
-
Rodrigo
-
Rodrigo Tobar