[issue46291] [doc] First argument to raise can also be BaseException
New submission from Gregor Titze <gregor.titze@gmail.com>: The Python Tutorial describes the first argument to the raise statement as follows: """ This must be either an exception instance or an exception class (a class that derives from Exception). """ https://docs.python.org/3/tutorial/errors.html#raising-exceptions However, the Python Language Reference states, that exceptions should be a subclass or instance of BaseException. https://docs.python.org/3/reference/simple_stmts.html#grammar-token-python-g... I think it would be correct, to adapt the Tutorial to match the Reference. ---------- assignee: docs@python components: Documentation messages: 409961 nosy: docs@python, gtitze priority: normal severity: normal status: open title: [doc] First argument to raise can also be BaseException type: enhancement versions: Python 3.10, Python 3.11, Python 3.6, Python 3.7, Python 3.8, Python 3.9 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Nikita Sobolev <mail@sobolevn.me> added the comment: I think that this is intentional: tutorial gives some very basic ideas about what can be raised. Giving the whole context (you can `raise` two kinds of errors: `Exception` and `BaseException`, but they are different, should be used in different cases, and they are caught differently). Probably most users don't need to subclass `BaseException` at all. And if they need to: there are docs for that https://docs.python.org/3/library/exceptions.html#BaseException In my opinion - nothing should be changed there :) ---------- nosy: +sobolevn _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Irit Katriel <iritkatriel@gmail.com> added the comment: If you scroll up, you can see that BaseException was mentioned above: "All exceptions inherit from BaseException, and so it can be used to serve as a wildcard" so I don't think it will add confusion to fix this. And it will be more accurate. Gregor, would you like to submit a patch? ---------- nosy: +iritkatriel _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Andre Roberge <andre.roberge@gmail.com> added the comment: In https://docs.python.org/3/library/exceptions.html#Exception, it is written: "All built-in, non-system-exiting exceptions are derived from this class. All user-defined exceptions should also be derived from this class." Yes, technically, the root of all exceptions is BaseException. However, this seems to indicate that the advice given in the tutorial is correct. ---------- nosy: +aroberge _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Irit Katriel <iritkatriel@gmail.com> added the comment: Andre, I don't follow. The OP is reporting an issue with a line about raising exceptions. Why is it correct to advise us to raise only Exception subclasses? ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Irit Katriel <iritkatriel@gmail.com> added the comment: There are other issues in this doc: 1. The paragraph starting with "The except clause may specify a variable after the exception name.." appears after this face was used in an example. It should move up. 2. In the User-defined Exceptions Section, there is a link to the Classes tutorial in the beginning "(See Classes for more about Python classes)", and another one at the end, "More information on classes it presented in chapter Classes". The second one can be removed. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Change by Irit Katriel <iritkatriel@gmail.com>: ---------- versions: -Python 3.6, Python 3.7, Python 3.8 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Change by Irit Katriel <iritkatriel@gmail.com>: ---------- keywords: +easy _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Andre Roberge <andre.roberge@gmail.com> added the comment: Irit: Gregor indicates that, while the tutorial refers to "a class that derives from Exception", the Python Reference Language states exceptions should be subclasses of BaseException (which Exception *is*). You then invited Gregor to submit a patch to change the wording of the tutorial (implying that it would refer to a class that derives from BaseException). I pointed out that the advice given elsewhere is that user-defined exceptions should derive from Exception (thus, not from BaseException), so that nothing should be changed in the tutorial, and no change should be submitted. So, as I understand it: there is a strict hierarchy of exceptions classes, all inheriting from BaseException. However, user-defined exceptions should be derived from Exception (and not BaseException), as indicated in the tutorial and on the page describing what each exception indicates. If that is correct, nothing needs to be changed in the tutorial. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Irit Katriel <iritkatriel@gmail.com> added the comment: Andre, are you saying that we should only RAISE Exception subclasses? ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Andre Roberge <andre.roberge@gmail.com> added the comment: Irit: In all the books and tutorials I have seen, the advice is to try to catch specific exceptions whenever possible or, *at most*, to catch Exception (and not BaseException). This is to allow, for example, a program to be interrupted by a KeyboardInterrupt. As you know, the hierarchy is as follows: BaseException +-- SystemExit +-- KeyboardInterrupt +-- GeneratorExit +-- Exception +-- all others If specific action to do some cleanup before a SystemExit (usually the result of calling sys.exit()) or catching some KeyboardInterrupt (which is generally NOT done via a raise statement), then these specific exception should be caught. The documentation refers to GeneratorExit as not indicating an error needing to be caught by users. For this advice (catching Exception and not BaseException) to be correct, users should be advised (as they are in the tutorial) to raise exceptions derived from Exception (and not BaseException). ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Irit Katriel <iritkatriel@gmail.com> added the comment:
For this advice (catching Exception and not BaseException) to be correct, users should be advised (as they are in the tutorial) to raise exceptions derived from Exception (and not BaseException).
I disagree with that. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Andre Roberge <andre.roberge@gmail.com> added the comment:
For this advice (catching Exception and not BaseException) to be correct, users should be advised (as they are in the tutorial) to raise exceptions derived from Exception (and not BaseException).
I disagree with that.
You are a core developer and I just an end-user. I respect your expertise and will no longer comment. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Gregor Titze <gregor.titze@gmail.com> added the comment: Andre: You mention that user-defined exceptions should inherit from Exception. This is totally right and explicitly stated just a bit later in 8.6 on the same page of the tutorial. I think this perfectly covers this concern . However, the paragraph I refer to explains the raise statement and as stated in the reference, the raise statement must be followed by a class or instance derived from BaseException. Thus, I think it would just be accurate and people reading on don't stumble over this difference as I did. Regarding the mentioned wildcard: I think it wouldn't be a real wildcard anymore if it didn't catch ALL exceptions. Anyway the tutorial states that it needs to be used with extreme caution and the example re-raises the error. Irit: Yes I am happy provide a patch. I would also correct the other two issues you mentioned. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Gregor Titze <gregor.titze@gmail.com> added the comment: Irit: I would move the paragraph starting with "The except clause may specify a variable after the exception name ..." and the following example before the paragraph starting with "All exceptions inherit from BaseException, and so it can be used to serve as a wildcard ..." Or did you have another position in mind? ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Irit Katriel <iritkatriel@gmail.com> added the comment: Make a PR and we can then tweak it via code reviews, it will be easier. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Vedran Čačić <vedgar@gmail.com> added the comment: Let me just say that I use `raise SystemExit` all the time. Beats `from sys import exit`, weird error messages about having to type parentheses, and surely beats "oh, am I on Windows so Ctrl+Z, or on Linux so Ctrl+D". :-] I also use `raise KeyboardInterrupt` sometimes in games, to test whether Ctrl+C handling works as expected at precise moments in the game (beats having to guess the millisecond in which to press Ctrl+C:). ---------- nosy: +veky _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Irit Katriel <iritkatriel@gmail.com> added the comment: @gtitze - are you still planning to work on this? ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
Change by Irit Katriel <iritkatriel@gmail.com>: ---------- keywords: +patch pull_requests: +29995 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31899 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue46291> _______________________________________
participants (5)
-
Andre Roberge -
Gregor Titze
-
Irit Katriel
-
Nikita Sobolev
-
Vedran Čačić