[issue45600] First sentence in docs for os.environ
New submission from Andrei Kulakov <andrei.avk@gmail.com>: In os.eviron docs: https://docs.python.org/3.11/library/os.html#os.environ A mapping object representing the string environment. Should that be "... the process environment." ? ---------- assignee: docs@python components: Documentation messages: 404934 nosy: andrei.avk, docs@python priority: low severity: normal status: open title: First sentence in docs for os.environ type: enhancement versions: Python 3.11 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45600> _______________________________________
Eryk Sun <eryksun@gmail.com> added the comment: The os.environ description appears to be worded as the "string environment" in contrast to the os.environb "environment as byte strings". I like the emphasis on the "process environment". How about "A mapping object of key and value strings that represent the process environment"? ---------- nosy: +eryksun _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45600> _______________________________________
Change by Andrei Kulakov <andrei.avk@gmail.com>: ---------- keywords: +patch pull_requests: +27473 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29204 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45600> _______________________________________
Andrei Kulakov <andrei.avk@gmail.com> added the comment: Eryk: sounds much better and clearer I think, I've put up a PR (that also does the same update to os.environb). ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45600> _______________________________________
Change by Andrei Kulakov <andrei.avk@gmail.com>: ---------- nosy: +kj _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45600> _______________________________________
Łukasz Langa <lukasz@langa.pl> added the comment: New changeset b17cfd150f4dc2816975d304a71110a2d445eaf0 by andrei kulakov in branch 'main': bpo-45600: Enhanced / clarified the docs for os.environ and os.environb (GH-29204) https://github.com/python/cpython/commit/b17cfd150f4dc2816975d304a71110a2d44... ---------- nosy: +lukasz.langa _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45600> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +27591 pull_request: https://github.com/python/cpython/pull/29321 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45600> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +27592 pull_request: https://github.com/python/cpython/pull/29322 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45600> _______________________________________
Łukasz Langa <lukasz@langa.pl> added the comment: New changeset 0538351fcaa320e62cb4ef92ec629b7e24a73e9c by Miss Islington (bot) in branch '3.10': bpo-45600: Enhanced / clarified the docs for os.environ and os.environb (GH-29204) (GH-29322) https://github.com/python/cpython/commit/0538351fcaa320e62cb4ef92ec629b7e24a... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45600> _______________________________________
Łukasz Langa <lukasz@langa.pl> added the comment: New changeset 3ec1124de289496efabc43a02cc88b3c59e1e238 by Miss Islington (bot) in branch '3.9': bpo-45600: Enhanced / clarified the docs for os.environ and os.environb (GH-29204) (GH-29321) https://github.com/python/cpython/commit/3ec1124de289496efabc43a02cc88b3c59e... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45600> _______________________________________
Łukasz Langa <lukasz@langa.pl> added the comment: Thanks, Andrei! ✨ 🍰 ✨ ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.9 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue45600> _______________________________________
participants (4)
-
Andrei Kulakov -
Eryk Sun
-
miss-islington
-
Łukasz Langa