Mailman 3 October 2016 - docs

Remove support of bytes paths in os.scandir() (issue 27998)
by eryksun+pybugs＠gmail.com 08 Oct '16

08 Oct '16

http://bugs.python.org/review/27998/diff/18802/Modules/posixmodule.c File Modules/posixmodule.c (right): http://bugs.python.org/review/27998/diff/18802/Modules/posixmodule.c#newcod… Modules/posixmodule.c:11159: PyObject *unicode = self->path; How about consolidating this function as follows? static PyObject * path_object_error(PyObject *path) { #ifdef MS_WINDOWS return PyErr_SetExcFromWindowsErrWithFilenameObject( PyExc_OSError, 0, path); #else return PyErr_SetFromErrnoWithFilenameObject(PyExc_OSError, path); #endif } static PyObject * DirEntry_fetch_stat(DirEntry *self, int follow_symlinks) { int result; STRUCT_STAT st; PyObject *ub; #ifdef MS_WINDOWS if (PyUnicode_FSDecoder(self->path, &ub)) { const wchar_t *path = PyUnicode_AsUnicode(ub); #else /* POSIX */ if (PyUnicode_FSConverter(self->path, &ub)) { const char *path = PyBytes_AS_STRING(ub); #endif if (follow_symlinks) result = STAT(path, &st); else result = LSTAT(path, &st); Py_DECREF(ub); } else return NULL; if (result != 0) return path_object_error(self->path); return _pystat_fromstructstat(&st); } http://bugs.python.org/review/27998/

1 0

[issue28390] Wrong heading levels in whatsnew/3.6
by SilentGhost 08 Oct '16

08 Oct '16

New submission from SilentGhost: Couple of headings in whatsnew/3.6.rst have wrong level. The patch fixes this. ---------- assignee: docs@python components: Documentation files: headings.diff keywords: patch messages: 278296 nosy: SilentGhost, docs@python priority: normal severity: normal stage: patch review status: open title: Wrong heading levels in whatsnew/3.6 type: behavior versions: Python 3.6, Python 3.7 Added file: http://bugs.python.org/file45013/headings.diff _______________________________________ Python tracker <report(a)bugs.python.org> <http://bugs.python.org/issue28390> _______________________________________

3 2

[issue27998] Bytes paths now are supported in os.scandir() on Windows
by Serhiy Storchaka 08 Oct '16

08 Oct '16

Serhiy Storchaka added the comment: I suppose the following patch should fix the issue. Could anybody please test it on Windows? ---------- assignee: docs@python -> serhiy.storchaka stage: needs patch -> patch review Added file: http://bugs.python.org/file45009/direntry_bytes_path.patch _______________________________________ Python tracker <report(a)bugs.python.org> <http://bugs.python.org/issue27998> _______________________________________

1 0

[issue27998] Bytes paths now are supported in os.scandir() on Windows
by Serhiy Storchaka 08 Oct '16

08 Oct '16

Serhiy Storchaka added the comment: Hmm, tests are passed on some Windows buildbots, but failed on others. http://buildbot.python.org/all/builders/AMD64%20Windows10%203.x/builds/1631… ====================================================================== ERROR: test_walk_topdown (test.test_os.BytesWalkTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_os.py", line 890, in test_walk_topdown all = list(self.walk(self.walk_path)) File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_os.py", line 1055, in walk for broot, bdirs, bfiles in os.walk(os.fsencode(top), **kwargs): File "D:\buildarea\3.x.bolen-windows10\build\lib\os.py", line 409, in walk yield from walk(new_path, topdown, onerror, followlinks) File "D:\buildarea\3.x.bolen-windows10\build\lib\os.py", line 367, in walk is_dir = entry.is_dir() TypeError: bad argument type for built-in operation ---------------------------------------------------------------------- The error message is not very informative. Seems like some C API function takes an argument of wrong type (e.g. bytes instead of unicode). ---------- nosy: +ned.deily priority: normal -> release blocker _______________________________________ Python tracker <report(a)bugs.python.org> <http://bugs.python.org/issue27998> _______________________________________

1 0

Re: [docs] Make the documentation for statistics' data argument clearer. (issue 27825)
by steve+python＠pearwood.info 08 Oct '16

08 Oct '16

Thanks for the patch Mariatta. The addition of "a sequence or iterator" is good. I dislike the median_grouped() example and would like to see one which uses more plausible data values. http://bugs.python.org/review/27825/diff/18782/Doc/library/statistics.rst File Doc/library/statistics.rst (right): http://bugs.python.org/review/27825/diff/18782/Doc/library/statistics.rst#n… Doc/library/statistics.rst:241: >>> median_grouped([F(55, 7), F(52, 3), F(53, 3), F(5, 3)]) I dislike this example as it is misleading. median_grouped() will work with arbitrary numbers, as in this example, but the intention is that the numbers are the mid-point of data classes, often called "class marks". So you should expect that the data are equally-spaced values (median_grouped assumes a class interval of 1 by default, but it can be changed). Examples should be equally-spaced (possibly with gaps -- it is okay if a class has no values). Although median_grouped() will work with Fractions, I think it is unlikely that anyone would give it actual data in Fractions. I'd prefer to see more realistic examples: ints, floats or Decimals. Perhaps the documentation needs to define the relevant statistics terminology? "Class interval", "class mark", "class limits". See: http://mathworld.wolfram.com/ClassMark.html http://bugs.python.org/review/27825/

1 0

Re: [docs] Make the documentation for statistics' data argument clearer. (issue 27825)
by steve+python＠pearwood.info 08 Oct '16

08 Oct '16

> Adding 'sequence or iterator' is the wanted change, changing 'numeric' to > 'real-valued' changes the meaning. > Real-valued is more specific than numeric. > For example, does median work with complex numbers? with integers? Median requires that the data is sorted, which is undefined for complex numbers, so median won't work with complex numbers. Mathematically "real-valued" is correct and includes integers. Unfortunately Decimal is not fully part of the numeric tower in Python, a Decimal is a numbers.Number but not numbers.Real. I think it best if the median* functions refer to "non-complex numeric data". http://bugs.python.org/review/27825/

1 0

[issue28386] Improve documentation about tzinfo.dst(None)
by Daniel Moisset 07 Oct '16

07 Oct '16

New submission from Daniel Moisset: The datetime module documentation[1] describes the tzinfo.dst method with a single "dt" argument without being too explicit about possible values for it. The implication is that dt should be a datetime object, but the implementation of time.dst() [2] actually calls tz.dst(None) (where tz is an instance of some tzinfo subclass), so this should clarify that None is an allowed value. Also, some of the examples given below in the same document (like LocalTimezone, GMT1, GMT2) actually have a related bug (it doesn't handle a None value correctly). So running >>> ... # copy the example from the documentation >>> t = time(tzinfo=LocalTimeZone()) >>> t.dst() crashes with an AttributeError: 'NoneType' object has no attribute 'year'. This kind of bugs have propagated to some other projects already [2]. Some of the other examples (like USTimeZone) seem to be OK What I think would be desirable here is: * A clarification on https://docs.python.org/3.5/library/datetime.html#datetime.tzinfo.dst indicating that dt is either a datetime or a None, in which situations it can be None, and what is the method supposed to return in this case. * Fixes in the code examples that reflect this I would offer a patch, but I'm not quite sure of what the desired behaviour is so I wouldn't know what to document :) [1] https://docs.python.org/3.5/library/datetime.html [2] https://github.com/python/cpython/blob/master/Modules/_datetimemodule.c#L36… [3] https://github.com/django/django/blob/1.10.2/django/utils/timezone.py#L111 ---------- assignee: docs@python components: Documentation messages: 278256 nosy: Daniel Moisset, docs@python priority: normal severity: normal status: open title: Improve documentation about tzinfo.dst(None) _______________________________________ Python tracker <report(a)bugs.python.org> <http://bugs.python.org/issue28386> _______________________________________

3 2

Re: [docs] Make the documentation for statistics' data argument clearer. (issue 27825)
by mariatta.wijaya＠gmail.com 07 Oct '16

07 Oct '16

Thanks for the feedback. I will update based on your suggestion. http://bugs.python.org/review/27825/diff/18782/Doc/library/statistics.rst File Doc/library/statistics.rst (right): http://bugs.python.org/review/27825/diff/18782/Doc/library/statistics.rst#n… Doc/library/statistics.rst:151: *data* can be a sequence or iterator of real-valued numbers. On 2016/10/07 19:18:33, efm wrote: > Adding 'sequence or iterator' is the wanted change, changing 'numeric' to > 'real-valued' changes the meaning. > Real-valued is more specific than numeric. > For example, does median work with complex numbers? with integers? Thanks for the feedback! I think you are right on this. I will make the change :) http://bugs.python.org/review/27825/

1 0

Make the documentation for statistics' data argument clearer. (issue 27825)
by efm-pythonbugs＠tummy.com 07 Oct '16

07 Oct '16

New examples using Fraction look good. Sequence or iterator change also good. Modifying numeric to become real-valued is a significant change in meaning. It's more specific than is needed. http://bugs.python.org/review/27825/diff/18782/Doc/library/statistics.rst File Doc/library/statistics.rst (right): http://bugs.python.org/review/27825/diff/18782/Doc/library/statistics.rst#n… Doc/library/statistics.rst:151: *data* can be a sequence or iterator of real-valued numbers. Adding 'sequence or iterator' is the wanted change, changing 'numeric' to 'real-valued' changes the meaning. Real-valued is more specific than numeric. For example, does median work with complex numbers? with integers? http://bugs.python.org/review/27825/diff/18782/Doc/library/statistics.rst#n… Doc/library/statistics.rst:163: >>> median([F(3, 7), F(1, 21), F(5, 3), F(1, 3)]) This is a nice choice of an example. http://bugs.python.org/review/27825/diff/18782/Doc/library/statistics.rst#n… Doc/library/statistics.rst:183: :exc:`StatisticsError` is raised. *data* can be a sequence or iterator See my comment above. Real-valued may be too specific. http://bugs.python.org/review/27825/

1 0

Re: [docs] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial (issue 28315)
by jaysinhp＠gmail.com 07 Oct '16

07 Oct '16

On 2016/10/04 20:52:21, Mariatta wrote: > Thanks for the patches, Jaysinh. > > In some of these patches, the word 'in' is missing. > > For example, it should have been > ... line 1, in <module> > > instead, I'm seeing > ... line 1, <module> > > Thanks :) > > http://bugs.python.org/review/28315/diff/18761/Doc/library/ctypes.rst > File Doc/library/ctypes.rst (right): > > http://bugs.python.org/review/28315/diff/18761/Doc/library/ctypes.rst#newco… > Doc/library/ctypes.rst:100: File "<stdin>", line 1, <module> > The word 'in' is missing, > eg > File "<stdin>", line 1, in <module> > > http://bugs.python.org/review/28315/diff/18762/Doc/library/ctypes.rst > File Doc/library/ctypes.rst (right): > > http://bugs.python.org/review/28315/diff/18762/Doc/library/ctypes.rst#newco… > Doc/library/ctypes.rst:90: File "<stdin>", line 1, <module> > Should be > in <module> > > http://bugs.python.org/review/28315/diff/18763/Doc/library/ctypes.rst > File Doc/library/ctypes.rst (right): > > http://bugs.python.org/review/28315/diff/18763/Doc/library/ctypes.rst#newco… > Doc/library/ctypes.rst:100: File "<stdin>", line 1, <module> > It should say ", in <module>" Hello Maroatta, Thanks for reviewing my patches. I have uploaded the new patches. Could you please review them again? Many thanks! http://bugs.python.org/review/28315/

1 0