[issue43804] Add more info about building C/C++ Extensions on Windows using MSVC
New submission from Shreyan Avigyan <shreyan.avigyan@gmail.com>: In the context of Docs/extending/windows.rst, the command provided, for compiling the source code and linking the libraries to create a DLL, only works for Python 32-bit versions. But the documentation doesn't inform anything about that. The PR linked with this issue adds a note section with the text :- """ The above commands are only applicable for Python 32-bit versions. """ This PR is against the master branch and if accepted, it needs to be backported to all the previous supported versions. Kindly have a review of my PR. Thanking you, With Regards ---------- assignee: docs@python components: Documentation messages: 390773 nosy: docs@python, shreyanavigyan priority: normal severity: normal status: open title: Add more info about building C/C++ Extensions on Windows using MSVC versions: Python 3.10, Python 3.6, Python 3.7, Python 3.8, Python 3.9 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43804> _______________________________________
Change by Shreyan Avigyan <shreyan.avigyan@gmail.com>: ---------- keywords: +patch pull_requests: +24077 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25343 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43804> _______________________________________
Shreyan Avigyan <shreyan.avigyan@gmail.com> added the comment: Kindly have a review of my PR. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43804> _______________________________________
Shreyan Avigyan <shreyan.avigyan@gmail.com> added the comment: Kindly have a review of my PR. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43804> _______________________________________
Shreyan Avigyan <shreyan.avigyan@gmail.com> added the comment: Please have a review. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43804> _______________________________________
Shreyan Avigyan <shreyan.avigyan@gmail.com> added the comment: Kindly have a review of my PR. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43804> _______________________________________
Shreyan Avigyan <shreyan.avigyan@gmail.com> added the comment: Kindly have a review of my patch ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43804> _______________________________________
Shreyan Avigyan <shreyan.avigyan@gmail.com> added the comment: Ping ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43804> _______________________________________
Zachary Ware <zachary.ware@gmail.com> added the comment: Please have some patience. Constant requests for review or pings are frankly quite annoying. Everyone on this project is a volunteer, and as such things only get done when someone has the time and inclination to do them. If your issue/PR has sat idle for a month or so, then it may be time to consider a ping, but a ping every two days will quickly come to be seen as spam and ignored. ---------- nosy: +zach.ware _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43804> _______________________________________
Change by Zachary Ware <zachary.ware@gmail.com>: ---------- components: +Windows nosy: +paul.moore, steve.dower, tim.golden stage: patch review -> needs patch title: Add more info about building C/C++ Extensions on Windows using MSVC -> "Building C and C++ Extensions on Windows" docs are very out-of-date versions: +Python 3.11 -Python 3.6, Python 3.7 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43804> _______________________________________
Steve Dower <steve.dower@python.org> added the comment: I agree with Zach's comment on the PR - this topic needs an overhaul. All the information required is going to be out there somewhere, and those of us on this issue can help fill in any gaps, but someone will need to spend a bit of time on research and laying it out nicely. This is a great contribution opportunity for someone who would rather contribute writing and research rather than just code. However, it is a tough area, and so any improvements will be pretty well scrutinised. Good docs here will be very impactful throughout the community, so let's make sure they're good. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43804> _______________________________________
Shreyan Avigyan <shreyan.avigyan@gmail.com> added the comment: Both https://docs.python.org/3/extending/windows.html#building-on-windows and https://docs.python.org/3/extending/building.html recommends using distutils. As mentioned in PEP 632 distutils will soon be deprecated. I think it'll be a good idea to change the docs to recommend using setuptools and also change the source code for setup.py to use setuptools instead of distutils. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43804> _______________________________________
Shreyan Avigyan <shreyan.avigyan@gmail.com> added the comment: I'm attaching a patch for improving "Building C and C++ Extensions on Windows" and "Building C and C++ Extensions" docs. ---------- Added file: https://bugs.python.org/file49973/patch.patch _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43804> _______________________________________
participants (3)
-
Shreyan Avigyan -
Steve Dower
-
Zachary Ware