[issue15055] dictnotes.txt is out of date
New submission from Mark Shannon <mark@hotpy.org>: dictnotes.txt is out of date w.r.t. dictobject.c Remove notes from dictnotes.txt that duplicate comments in dictobject.c and ensure comments in dictobject.c cover all aspects of tunable parameters. Patch attached. ---------- assignee: docs@python components: Documentation files: dictnotes.patch keywords: patch messages: 162709 nosy: Mark.Shannon, docs@python priority: normal severity: normal status: open title: dictnotes.txt is out of date type: enhancement versions: Python 3.3 Added file: http://bugs.python.org/file25947/dictnotes.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue15055> _______________________________________
Changes by Raymond Hettinger <raymond.hettinger@gmail.com>: ---------- assignee: docs@python -> rhettinger nosy: +rhettinger _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue15055> _______________________________________
Raymond Hettinger <raymond.hettinger@gmail.com> added the comment: Mark, where was it approved that you could change all the tunable parameters? I remembered that the split dict was approved but not changing all of the tuneables (at one point, I had spent a month validating that the tuneables were correct across a wide variety of applications). ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue15055> _______________________________________
Mark Shannon <mark@hotpy.org> added the comment: Raymond, I don't think this is the place to discuss the changes to the tunables in dictobject.c. This patch merely ensures that dictnotes.txt and the comments in dictobject.c are in agreement. It doesn't change any code (apart from creating the GROWTH_RATE macro for clarity). ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue15055> _______________________________________
Mark Shannon <mark@hotpy.org> added the comment: Is there any reason not to commit this patch? The docs are out of sync with the code and need to be updated. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue15055> _______________________________________
Roundup Robot <devnull@psf.upfronthosting.co.za> added the comment: New changeset 1120041f2df4 by Antoine Pitrou in branch 'default': Issue #15055: update dictnotes.txt. Patch by Mark Shannon. http://hg.python.org/cpython/rev/1120041f2df4 ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue15055> _______________________________________
Antoine Pitrou <pitrou@free.fr> added the comment: Sorry, Mark. This is committed now. ---------- assignee: rhettinger -> nosy: +pitrou resolution: -> fixed stage: -> committed/rejected status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue15055> _______________________________________
Mark Shannon <mark@hotpy.org> added the comment: No apology needed :) Thanks. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue15055> _______________________________________
participants (4)
-
Antoine Pitrou -
Mark Shannon
-
Raymond Hettinger
-
Roundup Robot