[issue8855] Shelve documentation lacks security warning

New submission from Longpoke <longpoke@gmail.com>: Loading a shelve can cause arbitrary code to be executed [1] and other black magic (because it's backed by Pickle). Shouldn't there be a big fat warning at the top of the shelve documentation page? Unless you're like me and assume anything to do with serialization in any language is insecure until proved otherwise, you aren't going to intuitively think there is anything wrong with "unshelving" untrusted data (unless you already know that Pickle is insecure). 1. http://nadiana.com/python-pickle-insecure#comment-261 ---------- assignee: docs@python components: Documentation messages: 106746 nosy: docs@python, q94IjzUfnNoyv4c75mMw priority: normal severity: normal status: open title: Shelve documentation lacks security warning _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8855> _______________________________________

Éric Araujo <merwok@netwok.org> added the comment: Thank you for the report. Would you like to propose a patch against the py3k branch? ---------- nosy: +eric.araujo stage: -> needs patch versions: +Python 2.7, Python 3.1, Python 3.2 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8855> _______________________________________

Longpoke <longpoke@gmail.com> added the comment: Okay I've attached one for the py3k branch. What about 2.7? Same patch applies there. ---------- keywords: +patch Added file: http://bugs.python.org/file18645/shelve.rst.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8855> _______________________________________

Georg Brandl <georg@python.org> added the comment: Committed in r85612, will be merged to the other maintained branches. ---------- nosy: +georg.brandl resolution: -> fixed status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8855> _______________________________________
participants (3)
-
Georg Brandl
-
Longpoke
-
Éric Araujo