[issue18871] Be more stringent about the test suite
New submission from Antoine Pitrou: Here is a proposal to make the devguide more precise and explicit about needing to run the entire test suite before committing a change. ---------- assignee: docs@python components: Devguide, Documentation files: test_suite.patch keywords: patch messages: 196405 nosy: asvetlov, docs@python, eric.araujo, ezio.melotti, ncoghlan, pitrou, r.david.murray priority: normal severity: normal status: open title: Be more stringent about the test suite type: enhancement versions: 3rd party Added file: http://bugs.python.org/file31500/test_suite.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18871> _______________________________________
R. David Murray added the comment: Looks OK to me. Do we want to also recommend more explicitly that the tests be run with -uall? ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18871> _______________________________________
Antoine Pitrou added the comment: I don't know. I wouldn't insist too much on -uall, because generally it won't find anything more (except for network tests, perhaps). ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18871> _______________________________________
Nick Coghlan added the comment: Looks good to me. I think it's OK to leave the optional resources in the set of things covered by the buildbots rather than expecting them to always be run in pre-commit testing. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18871> _______________________________________
Roundup Robot added the comment: New changeset a62bb0481ac9 by Antoine Pitrou in branch 'default': Issue #18871: make it more explicit that the test suite should be run before committing http://hg.python.org/devguide/rev/a62bb0481ac9 ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18871> _______________________________________
Antoine Pitrou added the comment: Thanks for allowing me to be lazy, Nick :-) ---------- resolution: -> fixed stage: -> committed/rejected status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18871> _______________________________________
Nick Coghlan added the comment: The fact I don't run the tests with - uall before committing had nothing to do with it whatsoever. Nope. Nothing at all ;) ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18871> _______________________________________
participants (4)
-
Antoine Pitrou -
Nick Coghlan
-
R. David Murray
-
Roundup Robot