[issue39348] wrong rst syntax in socket.rst
New submission from Oz Tiram <nahumoz@gmail.com>: The code block for the isn't hightlighted: Changed in version 3.7: When SOCK_NONBLOCK or SOCK_CLOEXEC bit flags are applied to type they are cleared, and socket.type will not reflect them. They are still passed to the underlying system socket() call. Therefore:: sock = socket.socket( ... This is because the double colon is directly after the word Therefore. This fix is very simple: :attr:`socket.type` will not reflect them. They are still passed - to the underlying system `socket()` call. Therefore:: + to the underlying system `socket()` call. Therefore, + + :: sock = socket.socket( socket.AF_INET, ... I have prepared a PR for this. ---------- assignee: docs@python components: Documentation messages: 360086 nosy: Oz.Tiram, docs@python priority: normal severity: normal status: open title: wrong rst syntax in socket.rst versions: Python 3.7, Python 3.8, Python 3.9 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39348> _______________________________________
Change by Oz Tiram <nahumoz@gmail.com>: ---------- keywords: +patch pull_requests: +17413 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18018 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39348> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset fad8b5674c66d9e00bb788e30adddb0c256c787b by Miss Islington (bot) (Oz N Tiram) in branch 'master': bpo-39348: Fix code highlight for the SOCK_NONBLOCK example (GH-18018) https://github.com/python/cpython/commit/fad8b5674c66d9e00bb788e30adddb0c256... ---------- nosy: +miss-islington _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39348> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +17414 pull_request: https://github.com/python/cpython/pull/18019 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39348> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +17415 pull_request: https://github.com/python/cpython/pull/18020 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39348> _______________________________________
Change by Mariatta <mariatta@python.org>: ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39348> _______________________________________
Mariatta <mariatta@python.org> added the comment: Thanks! ---------- nosy: +Mariatta _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39348> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset 970188c2d792133e2273924a987e0542659a676f by Miss Islington (bot) in branch '3.7': bpo-39348: Fix code highlight for the SOCK_NONBLOCK example (GH-18018) https://github.com/python/cpython/commit/970188c2d792133e2273924a987e0542659... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39348> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset 19bd3a18626b504dc92abb44019cad600c7ef221 by Miss Islington (bot) in branch '3.8': bpo-39348: Fix code highlight for the SOCK_NONBLOCK example (GH-18018) https://github.com/python/cpython/commit/19bd3a18626b504dc92abb44019cad600c7... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39348> _______________________________________
participants (3)
-
Mariatta -
miss-islington
-
Oz Tiram