Changes by Brett Cannon : ---------- nosy: +brett.cannon _______________________________________ Python tracker http://bugs.python.org/issue25509 _______________________________________

Memeplex added the comment: Brett, I'm not sure about that, notice that the "import hook" as is mentioned in the docs is just the current __import__ in the builtins module (which could have been replaced and in this sense would be a "hook") but not proper import hooks. I think the original distinction between PyImport_ImportModule and PyImport_Import is still sensible today. Originally PyImport_ImportModule directly called the import machinery, while PyImport_Import called it indirectly through builtins.__import__ (which could have been replaced). Now, for some reason, for good or for bad, PyImport_ImportModule also goes through builtins.__import__. The documentation is wrong but what is the fix? Revert PyImport_ImportModule or redocument it? ---------- _______________________________________ Python tracker http://bugs.python.org/issue25509 _______________________________________

Brett Cannon added the comment: https://github.com/python/cpython/blob/45b34a04a577aa49fa4825421758c3e8eaa16... shows that the docs could be simplified to point out that `PyImport_ImportModule()` is a wrapper around `PyImport_Import()` which takes `const char *`. ---------- _______________________________________ Python tracker https://bugs.python.org/issue25509 _______________________________________

Change by Brett Cannon : ---------- keywords: +easy _______________________________________ Python tracker https://bugs.python.org/issue25509 _______________________________________