[issue28644] Document recen changes in typing.py
New submission from Ivan Levkivskyi: Here is the patch with recent additions/changes in typing.py Summary: Tuple and Callable are now classes, generic type aliases, added Coroutine, extended docs for get_type_hints. ---------- assignee: docs@python components: Documentation files: recent-typing-docs.diff keywords: patch messages: 280364 nosy: docs@python, gvanrossum, levkivskyi priority: normal severity: normal status: open title: Document recen changes in typing.py type: enhancement versions: Python 3.5, Python 3.6, Python 3.7 Added file: http://bugs.python.org/file45401/recent-typing-docs.diff _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28644> _______________________________________
Ivan Levkivskyi added the comment: Sorry, here is the patch with corrected formatting and base classes for Coroutine. ---------- Added file: http://bugs.python.org/file45402/recent-typing-docs-v2.diff _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28644> _______________________________________
Mariatta Wijaya added the comment: Hi Ivan, I noticed you used two space indentation in your docs patch. Can you use 3 spaces instead? More guidelines here: https://docs.python.org/devguide/documenting.html?#use-of-whitespace Thanks :) ---------- nosy: +Mariatta _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28644> _______________________________________
Ivan Levkivskyi added the comment: Thanks Mariatta, here is a new version of patch with indentation fixed. ---------- Added file: http://bugs.python.org/file45405/recent-typing-docs-v3.diff _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28644> _______________________________________
Ivan Levkivskyi added the comment: Guido, here is a new patch with your comments implemented. ---------- Added file: http://bugs.python.org/file45424/recent-typing-docs-v4.diff _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28644> _______________________________________
Changes by Guido van Rossum <guido@python.org>: ---------- title: Document recen changes in typing.py -> Document recent changes in typing.py _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28644> _______________________________________
Ivan Levkivskyi added the comment: Guido, here is the new patch with your corrections. I have some questions in Rietveld, but those are about mypy, you could apply the patch now. ---------- Added file: http://bugs.python.org/file45446/recent-typing-docs-v5.diff _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28644> _______________________________________
Changes by Ivan Levkivskyi <levkivskyi@gmail.com>: Added file: http://bugs.python.org/file45447/recent-typing-docs-v6.diff _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28644> _______________________________________
Roundup Robot added the comment: New changeset 5bf2ea0d3830 by Guido van Rossum in branch '3.5': Issue 28644: Document recent changes in typing.py (Ivan L) https://hg.python.org/cpython/rev/5bf2ea0d3830 New changeset 72a2c90abdec by Guido van Rossum in branch '3.6': Issue 28644: Document recent changes in typing.py (Ivan L) (3.5->3.6) https://hg.python.org/cpython/rev/72a2c90abdec New changeset c4394da344b7 by Guido van Rossum in branch 'default': Issue 28644: Document recent changes in typing.py (Ivan L) (3.6->3.7) https://hg.python.org/cpython/rev/c4394da344b7 ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28644> _______________________________________
Changes by Guido van Rossum <guido@python.org>: ---------- resolution: -> fixed stage: -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28644> _______________________________________
participants (4)
-
Guido van Rossum -
Ivan Levkivskyi
-
Mariatta Wijaya
-
Roundup Robot