[issue34733] Missing search bar on docs.python.org
New submission from Harrison Chudleigh <harrison.chudleigh1@education.nsw.gov.au>: The search bar is missing from docs.python.org, probably as a result of a minor error in the webpage. This is a quite recent change, as the search bar is still there in a web.archive.org snapshot from the 13th of September (last week). Could someone please fix this? Thanks. ---------- assignee: docs@python components: Documentation messages: 325737 nosy: Harrison Chudleigh, docs@python priority: normal severity: normal status: open title: Missing search bar on docs.python.org type: behavior _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Karthikeyan Singaravelan <tir.karthi@gmail.com> added the comment: Strange it's present on both 3.8.a0 and for 3.6.6 but not for 3.7.0 Thanks ---------- nosy: +xtreak _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Change by Ned Deily <nad@python.org>: ---------- nosy: +mdk _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Carol Willing <willingc@gmail.com> added the comment: Confirming that I see the same behavior as reported by @xtreak. ---------- nosy: +willingc stage: -> needs patch versions: +Python 3.7 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Julien Palard <julien+python@palard.fr> added the comment: I can reproduce it locally [1]. The Python logo at the left dissapear to, it goes from "[LOGO] Python »" to "3.7.0 Documentation »". Did not spotted recent changes in the theme / docsbuild-scripts / cpython/Doc for the moment, but now I can inspect locally. Local reproduction with a fresh clone of docsbuild-scripts: $ mkdir -p www logs build_root $ python3 -m venv build_root/venv/ $ build_root/venv/bin/python -m pip install -r requirements.txt $ python3 ./build_docs.py --quick --build-root build_root --www-root www --log-directory logs --group $(id -g) --branch 3.7 $ (cd www/3.7/; python3 -m http.server) ---------- stage: needs patch -> _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Julien Palard <julien+python@palard.fr> added the comment: I got it back by building with 90f7d455b (7 days ago), so I'm git bisecting... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Carol Willing <willingc@gmail.com> added the comment: @mdk The asyncio folks did make a change to the layout in https://github.com/python/cpython/pull/9364 . It's a bit weird that 3.7 is the release that is missing the search bar. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Julien Palard <julien+python@palard.fr> added the comment: Yes, got it too : 512d7101098b971837cbb406942215244f636547, they literally removed the searchbox: $ git show 512d7101098b971837cbb406942215244f636547 | grep searchbox -{%- macro searchbox() %} -{# modified from sphinx/themes/basic/searchbox.html #} - {{ searchbox() }} - '<input type="text" value="" id="searchbox" style="width: 50%">', - '<input type="submit" id="searchbox-submit" value="Filter"></p>' - var query = new RegExp($('#searchbox').val(), 'i'); - $('#searchbox').keyup(dofilter); - $('#searchbox-submit').click(dofilter); ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Change by Julien Palard <julien+python@palard.fr>: ---------- nosy: +yselivanov _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Yury Selivanov <yselivanov@gmail.com> added the comment: Oh, this is a result of asyncio docs 3.8 -> 3.7 backport. I'll fix this. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Carol Willing <willingc@gmail.com> added the comment: Does master and 3.7 branch build the docs at different times? It's odd to me that master still shows the search box and 3.7 does not. I'm getting on a flight soon. Yury would be a good person to ping re: changing. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Julien Palard <julien+python@palard.fr> added the comment: Thanks Yuri (and thanks for the rewrite!) ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Change by Yury Selivanov <yselivanov@gmail.com>: ---------- keywords: +patch pull_requests: +8848 stage: -> patch review _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Yury Selivanov <yselivanov@gmail.com> added the comment:
Does master and 3.7 branch build the docs at different times? It's odd to me that master still shows the search box and 3.7 does not.
layout.html was refactored in 3.8: scripts were moved into separate files. I accidentally copied it from 3.8 to 3.7, where those new scripts are not available. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Yury Selivanov <yselivanov@gmail.com> added the comment: New changeset 581890cda36f60cd46185c6e184abe35a95813a2 by Yury Selivanov in branch '3.7': bpo-34733: Return of the docs search bar (GH-9431) https://github.com/python/cpython/commit/581890cda36f60cd46185c6e184abe35a95... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Yury Selivanov <yselivanov@gmail.com> added the comment: Closing this now, please reopen if there's still no search bar in a few hours. ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
Yury Selivanov <yselivanov@gmail.com> added the comment: Aaand... it's back. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue34733> _______________________________________
participants (6)
-
Carol Willing -
Harrison Chudleigh
-
Julien Palard
-
Karthikeyan Singaravelan
-
Ned Deily
-
Yury Selivanov