[issue14124] _pickle.c comment/documentation improvement
New submission from Merlijn van Deen <valhallasw@gmail.com>: As suggested by loewis in msg154233, I created some documentation to help people get started with _pickle.c. ---------- assignee: docs@python components: Documentation, Extension Modules files: _pickle_c_doc.diff keywords: patch messages: 154284 nosy: docs@python, valhallasw priority: normal severity: normal status: open title: _pickle.c comment/documentation improvement type: enhancement versions: Python 3.3 Added file: http://bugs.python.org/file24641/_pickle_c_doc.diff _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue14124> _______________________________________
Changes by Merlijn van Deen <valhallasw@gmail.com>: ---------- nosy: +loewis _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue14124> _______________________________________
Mark Lawrence added the comment: Can we have a patch review on this please ---------- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.3 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue14124> _______________________________________
Serhiy Storchaka added the comment: Using absolute line numbers in comments looks bad idea to me. This becomes outdated very fast. The code of _pickle.c was changed many times since writing the patch. ---------- nosy: +serhiy.storchaka status: open -> pending _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue14124> _______________________________________
Change by Serhiy Storchaka <storchaka+cpython@gmail.com>: ---------- resolution: -> rejected stage: -> resolved status: pending -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue14124> _______________________________________
participants (3)
-
Mark Lawrence
-
Merlijn van Deen
-
Serhiy Storchaka