Rémi Lapeyre added the comment: In general examples in the documentation may lack some things like imports as they are implicit but in this case it also lack do_work(), source() and num_worker_threads. You could use os.cpu_count() instead of your hard-coded value and the comment. Can you open a pull request with your change? ---------- nosy: +remi.lapeyre _______________________________________ Python tracker https://bugs.python.org/issue40387 _______________________________________

Raymond Hettinger added the comment: The example is supposed to be a sketch of the overall pattern. IMO, putting concrete and useless implementations of do_work() and source() make the example less intelligible. Instead, we can add a note that the user needs to supply their own do_work() and source(). ---------- nosy: +rhettinger _______________________________________ Python tracker https://bugs.python.org/issue40387 _______________________________________

Raymond Hettinger added the comment: I'm thinking of simplifying the example to focus on its core goal of demonstrating how to enqueue tasks and then wait for them to be finished: import threading, queue q = queue.Queue() def worker(): while True: item = q.get() print(f'Working on {item}') print(f'Finished {item}') q.task_done() # turn-on the worker thread worker_thread = threading.Thread(target=worker) worker_thread.daemon = True worker_thread.start() # send thirty task requests to the worker for item in range(30): q.put(item) print('All task requests sent\n', end='') # block until all tasks are done q.join() print('All work completed') ---------- assignee: docs@python -> rhettinger title: queue example it does not work -> queue example is a sketch versions: -Python 3.7 _______________________________________ Python tracker https://bugs.python.org/issue40387 _______________________________________

Santiago Blanco added the comment: That is pretty clear! Thank you Raymond. ---------- _______________________________________ Python tracker https://bugs.python.org/issue40387 _______________________________________

Change by miss-islington : ---------- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +19048 pull_request: https://github.com/python/cpython/pull/19726 _______________________________________ Python tracker https://bugs.python.org/issue40387 _______________________________________

Change by Raymond Hettinger : ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker https://bugs.python.org/issue40387 _______________________________________