[issue38413] Remove or change "Multithreading" section
New submission from Vladimir Ryabtsev greatvovan@gmail.com:
This is regarding the page https://docs.python.org/3.7/library/sqlite3.html.
I believe this section on the very bottom of the page has been kept here for pretty long time, during that both SQLite and the sqlite3 module evolved and improved. Now the content contradicts to the description of function "connect()" in the part describing "check_same_thread" parameter. The function description says that using connections from multiple threads is allowed with serialization handled by the user (and it is true), while the bottom "Mutithreading" section says sharing connections is not allowed.
I think we can remove "Mutithreading" section entirely unless there is something important to add to what already mentioned.
---------- assignee: docs@python components: Documentation messages: 354227 nosy: Vladimir Ryabtsev, docs@python priority: normal severity: normal status: open title: Remove or change "Multithreading" section versions: Python 3.7, Python 3.8, Python 3.9
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Change by David Kernan davidsmurf@gmail.com:
---------- keywords: +patch pull_requests: +16262 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16678
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Change by David Kernan davidsmurf@gmail.com:
---------- pull_requests: -16262
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Change by Brett Cannon brett@python.org:
---------- nosy: +ghaering
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Dima Tisnek dimaqq@gmail.com added the comment:
That would be nice; someone needs to figure out what exact sqlite version allows safe passing of connection between threads. Ideally other caveats would be covered (is passing open cursors to another thread allowed?, etc...)
---------- nosy: +Dima.Tisnek
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Vladimir Ryabtsev greatvovan@gmail.com added the comment:
I see no point in researching the version of sqlite, since Python does not allow user to specify it, you just use the compiled version that comes with Python distribution.
10 years now to the commit that introduced that piece of text: https://github.com/python/cpython/commit/c34d76cdc3212615f9a3c2c4b1c54259237...
Let's just remove it, what it says is simply not true.
----------
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Vladimir Ryabtsev greatvovan@gmail.com added the comment:
May by I was wrong above and it uses system's Sqlite... But anyway it does not cancel the fact that this section contradicts to another one.
----------
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Vladimir Ryabtsev greatvovan@gmail.com added the comment:
Also the footnote requires some minor corrections (formatting and style). I suggest the following wording:
To get loadable extension support, your Python must be compiled with ``-–enable-loadable-sqlite-extensions`` option in ``PYTHON_CONFIGURE_OPTS``.
I believe otherwise it is basically not clear what is said here.
----------
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Change by Vladimir Ryabtsev greatvovan@gmail.com:
---------- pull_requests: +22071 pull_request: https://github.com/python/cpython/pull/23159
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Berker Peksag berker.peksag@gmail.com added the comment:
New changeset f9949f82e17c88609adb53eff3a7d5cd63a645bd by Vladimir in branch 'master': bpo-38413: Remove outdated section about multithreading in sqlite3 (GH-23159) https://github.com/python/cpython/commit/f9949f82e17c88609adb53eff3a7d5cd63a...
---------- nosy: +berker.peksag
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Change by miss-islington mariatta.wijaya+miss-islington@gmail.com:
---------- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +22964 pull_request: https://github.com/python/cpython/pull/24134
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Berker Peksag berker.peksag@gmail.com added the comment:
New changeset 03a079f7cf8eacc29ea616060916e8a63ba6e5ba by Miss Islington (bot) in branch '3.8': bpo-38413: Remove outdated section about multithreading in sqlite3 (GH-23159) https://github.com/python/cpython/commit/03a079f7cf8eacc29ea616060916e8a63ba...
----------
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Change by Vladimir Ryabtsev greatvovan@gmail.com:
---------- pull_requests: +22974 pull_request: https://github.com/python/cpython/pull/24145
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Change by Vladimir Ryabtsev greatvovan@gmail.com:
---------- stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -Python 3.7
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Berker Peksag berker.peksag@gmail.com added the comment:
New changeset 49c150f1f16398a4e77e051244f27adc5ac7b47b by Vladimir in branch '3.9': bpo-38413: Remove outdated section about multithreading in sqlite3 (GH-23159) https://github.com/python/cpython/commit/49c150f1f16398a4e77e051244f27adc5ac...
----------
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
Change by Berker Peksag berker.peksag@gmail.com:
---------- resolution: -> fixed type: -> behavior
_______________________________________ Python tracker report@bugs.python.org https://bugs.python.org/issue38413 _______________________________________
participants (6)
-
Berker Peksag -
Brett Cannon
-
David Kernan
-
Dima Tisnek
-
miss-islington
-
Vladimir Ryabtsev