[issue21977] In the re's token example OP and SKIP regexes can be improved
New submission from py.user: https://docs.python.org/3/library/re.html#writing-a-tokenizer There are redundant escapes in the regex: ('OP', r'[+*\/\-]'), # Arithmetic operators Sequence -+*/ is sufficient. It makes the loop to do all steps on every 4 spaces: ('SKIP', r'[ \t]'), # Skip over spaces and tabs Sequence [ \t]+ is faster. Applied patch. ---------- assignee: docs@python components: Documentation, Regular Expressions files: re_ex_tok.diff keywords: patch messages: 223000 nosy: docs@python, ezio.melotti, mrabarnett, py.user priority: normal severity: normal status: open title: In the re's token example OP and SKIP regexes can be improved type: enhancement versions: Python 3.5 Added file: http://bugs.python.org/file35951/re_ex_tok.diff _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue21977> _______________________________________
Changes by Raymond Hettinger <raymond.hettinger@gmail.com>: ---------- assignee: docs@python -> rhettinger nosy: +rhettinger _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue21977> _______________________________________
Raymond Hettinger added the comment: I will keep the \- because the - at the front of the character range is a non-obvious special case. The other changes look reasonable. ---------- priority: normal -> low stage: -> commit review type: enhancement -> performance versions: +Python 2.7, Python 3.4 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue21977> _______________________________________
Roundup Robot added the comment: New changeset bb28542af060 by Raymond Hettinger in branch '3.4': Issue 21977: Minor improvements to the regexes in the tokenizer example. http://hg.python.org/cpython/rev/bb28542af060 ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue21977> _______________________________________
Changes by Raymond Hettinger <raymond.hettinger@gmail.com>: ---------- resolution: -> fixed status: open -> closed versions: -Python 2.7 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue21977> _______________________________________
Changes by Berker Peksag <berker.peksag@gmail.com>: ---------- stage: commit review -> resolved _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue21977> _______________________________________
participants (4)
-
Berker Peksag -
py.user
-
Raymond Hettinger
-
Roundup Robot