[issue8834] Define order of Misc/ACKS entries
New submission from Alexander Belopolsky <belopolsky@users.sourceforge.net>: This is a semi-serious feature request following a brief discussion on #python-dev IRC. Brett Cannon pointed out on python-checkins list [1] that the names should be alphabetized. However, given that the names are international, it is not obvious what it means. I propose to add a comment at the top of Misc/ACKS that the list is maintained in "rough alphabetical order" but not define it any further. [1] http://mail.python.org/pipermail/python-checkins/2010-May/093650.html ---------- assignee: docs@python components: Documentation messages: 106615 nosy: belopolsky, docs@python priority: normal severity: normal status: open title: Define order of Misc/ACKS entries type: feature request _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Changes by Alexander Belopolsky <belopolsky@users.sourceforge.net>: ---------- keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file17475/issue8834.diff _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Antoine Pitrou <pitrou@free.fr> added the comment: Looks good to me. ---------- nosy: +pitrou versions: +Python 2.6, Python 2.7, Python 3.1, Python 3.2 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Brett Cannon <brett@python.org> added the comment: LGTM as well. ---------- nosy: +brett.cannon _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Łukasz Langa <lukasz@langa.pl> added the comment: LGTM :) ---------- nosy: +lukasz.langa _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Changes by Giampaolo Rodola' <g.rodola@gmail.com>: ---------- nosy: +giampaolo.rodola _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Terry J. Reedy <tjreedy@udel.edu> added the comment: Only a few days left for 2.6 ;-) ---------- nosy: +terry.reedy _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Alexander Belopolsky <belopolsky@users.sourceforge.net> added the comment: Committed in release27-maint branch in r83893. I am not sure this belongs in 2.6 and there is a small practical problem with the merge due to Latin-1 encoding used in the 2.6 version. I am also not sure whether keeping separate 2.x and 3.x versions serves any useful purpose. I would like to merge 2.7 and 3.2 lists. I am about +0.5 on syncing all three versions after that. If the 2.6 has to stay in Latin-1, I would rather not touch it. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Terry J. Reedy <tjreedy@udel.edu> added the comment: At this point, I am sure that Barry would prefer leaving things alone for 2.6. I am surprised that there are separate lists. I thought there was just one which distributions grabbed when made. I suppose that one could claim that someone who only contributes to a branch after it branches off should not be listed for other branches, but in the absence of an automatic addition mechanism and dependence on hand-addition by committers, that does not work so well. Certainly, Guido's header does not specify 'this release'. ---------- versions: -Python 2.6, Python 2.7 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Alexander Belopolsky <belopolsky@users.sourceforge.net> added the comment: On Mon, Aug 9, 2010 at 2:16 PM, Terry J. Reedy <report@bugs.python.org> wrote: ..
I am surprised that there are separate lists. I thought there was just one which distributions grabbed when made.
I don't think this is intentional. More likely committers add acknowledgments in the same commit as the code changes and they end up in whatever branch the patch is applied to. I think this is fine, but from time to time the list should be merged to avoid svnmerge annoyances. Whoever is annoyed by svnmerge (like myself :-) should resync the lists. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Alexander Belopolsky <belopolsky@users.sourceforge.net> added the comment: Committed in r83937 (py3k) and r83938 (release31-maint). The py3k version is now a superset of the lists in the maintenance branches. I don't want to generate any more commit traffic by bringing all branches in sync. I'll leave it to the next committer who encounters a Misc/ACKS merge conflict which is now unlikely. I am closing with a link to python-dev discussion that r83893 generated. http://mail.python.org/pipermail/python-dev/2010-August/102960.html ---------- resolution: -> accepted stage: patch review -> committed/rejected status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Changes by Alexander Belopolsky <belopolsky@users.sourceforge.net>: ---------- keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file17475/issue8834.diff _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Antoine Pitrou <pitrou@free.fr> added the comment: Looks good to me. ---------- nosy: +pitrou versions: +Python 2.6, Python 2.7, Python 3.1, Python 3.2 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Brett Cannon <brett@python.org> added the comment: LGTM as well. ---------- nosy: +brett.cannon _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Łukasz Langa <lukasz@langa.pl> added the comment: LGTM :) ---------- nosy: +lukasz.langa _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Changes by Giampaolo Rodola' <g.rodola@gmail.com>: ---------- nosy: +giampaolo.rodola _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Terry J. Reedy <tjreedy@udel.edu> added the comment: Only a few days left for 2.6 ;-) ---------- nosy: +terry.reedy _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Alexander Belopolsky <belopolsky@users.sourceforge.net> added the comment: Committed in release27-maint branch in r83893. I am not sure this belongs in 2.6 and there is a small practical problem with the merge due to Latin-1 encoding used in the 2.6 version. I am also not sure whether keeping separate 2.x and 3.x versions serves any useful purpose. I would like to merge 2.7 and 3.2 lists. I am about +0.5 on syncing all three versions after that. If the 2.6 has to stay in Latin-1, I would rather not touch it. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Terry J. Reedy <tjreedy@udel.edu> added the comment: At this point, I am sure that Barry would prefer leaving things alone for 2.6. I am surprised that there are separate lists. I thought there was just one which distributions grabbed when made. I suppose that one could claim that someone who only contributes to a branch after it branches off should not be listed for other branches, but in the absence of an automatic addition mechanism and dependence on hand-addition by committers, that does not work so well. Certainly, Guido's header does not specify 'this release'. ---------- versions: -Python 2.6, Python 2.7 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Alexander Belopolsky <belopolsky@users.sourceforge.net> added the comment: On Mon, Aug 9, 2010 at 2:16 PM, Terry J. Reedy <report@bugs.python.org> wrote: ..
I am surprised that there are separate lists. I thought there was just one which distributions grabbed when made.
I don't think this is intentional. More likely committers add acknowledgments in the same commit as the code changes and they end up in whatever branch the patch is applied to. I think this is fine, but from time to time the list should be merged to avoid svnmerge annoyances. Whoever is annoyed by svnmerge (like myself :-) should resync the lists. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
Alexander Belopolsky <belopolsky@users.sourceforge.net> added the comment: Committed in r83937 (py3k) and r83938 (release31-maint). The py3k version is now a superset of the lists in the maintenance branches. I don't want to generate any more commit traffic by bringing all branches in sync. I'll leave it to the next committer who encounters a Misc/ACKS merge conflict which is now unlikely. I am closing with a link to python-dev discussion that r83893 generated. http://mail.python.org/pipermail/python-dev/2010-August/102960.html ---------- resolution: -> accepted stage: patch review -> committed/rejected status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue8834> _______________________________________
participants (6)
-
Alexander Belopolsky -
Antoine Pitrou
-
Brett Cannon
-
Giampaolo Rodola'
-
Terry J. Reedy
-
Łukasz Langa