[issue39616] SSLContext.check_hostname description is inaccurate wrt match_hostname
New submission from Ville Skyttä <ville.skytta@iki.fi>: Doc says "Whether to match the peer cert’s hostname with match_hostname() in SSLSocket.do_handshake()." but match_hostname() is no longer used to do that in the first place, OpenSSL is used for that. check_hostname affects the OpenSSL usage, too. ---------- assignee: docs@python components: Documentation messages: 361892 nosy: docs@python, scop priority: normal severity: normal status: open title: SSLContext.check_hostname description is inaccurate wrt match_hostname type: enhancement _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39616> _______________________________________
Change by Ville Skyttä <ville.skytta@iki.fi>: ---------- keywords: +patch pull_requests: +17857 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18484 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39616> _______________________________________
Change by Irit Katriel <iritkatriel@yahoo.com>: ---------- versions: +Python 3.10, Python 3.8, Python 3.9 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39616> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset 9798cef92b882cd82a338d3368eaf3c4a32f5c2d by Ville Skyttä in branch 'master': bpo-39616: clarify SSLContext.check_hostname effect (GH-18484) https://github.com/python/cpython/commit/9798cef92b882cd82a338d3368eaf3c4a32... ---------- nosy: +miss-islington _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39616> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +23784 pull_request: https://github.com/python/cpython/pull/25036 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39616> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +23785 pull_request: https://github.com/python/cpython/pull/25037 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39616> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset 9de6451558c38537b2335d6e04e3bf8743c30576 by Miss Islington (bot) in branch '3.8': bpo-39616: clarify SSLContext.check_hostname effect (GH-18484) https://github.com/python/cpython/commit/9de6451558c38537b2335d6e04e3bf8743c... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39616> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset c84e769c2b4108e1218e09652cb3bce34c541f8a by Miss Islington (bot) in branch '3.9': bpo-39616: clarify SSLContext.check_hostname effect (GH-18484) https://github.com/python/cpython/commit/c84e769c2b4108e1218e09652cb3bce34c5... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue39616> _______________________________________
participants (3)
-
Irit Katriel -
miss-islington
-
Ville Skyttä