[issue14303] Incorrect documentation for socket.py on linux
New submission from Shane Hansen <shanemhansen@gmail.com>: The python docs state that for socket.makefile "The file object references a dup()ped version of the socket file descriptor, so the file object and socket object may be closed or garbage-collected independently." In fact for socket.py dup() is never called, and no additional files are opened. Instead an object is returned which uses the original socket and does buffering. For me, this is the desired behaviour, but just thought I'd mention the docs were off. ---------- assignee: docs@python components: Documentation, IO files: test.py messages: 155768 nosy: Shane.Hansen, docs@python, georg.brandl, pitrou priority: normal severity: normal status: open title: Incorrect documentation for socket.py on linux type: behavior versions: Python 2.6, Python 2.7 Added file: http://bugs.python.org/file24843/test.py _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue14303> _______________________________________
Changes by Eric Snow <ericsnowcurrently@gmail.com>: ---------- nosy: +eric.snow _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue14303> _______________________________________
Mark Lawrence added the comment: Shane, there are major differences between the makefile docs versions 2 and 3, so could you prepare a patch for this addressed at version 2 only? ---------- nosy: +BreamoreBoy versions: -Python 2.6 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue14303> _______________________________________
Roundup Robot added the comment: New changeset 6e2a72e05b4f by Georg Brandl in branch '2.7': Closes #14303: socket.makefile() does not call dup() anymore on the socket fd. https://hg.python.org/cpython/rev/6e2a72e05b4f ---------- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue14303> _______________________________________
participants (4)
-
Eric Snow
-
Mark Lawrence
-
Roundup Robot
-
Shane Hansen