ysj.ray <ysj.ray@gmail.com> added the comment: `step` argument for xrange() could not be 0. But `s.stop or sys.maxint` is really a problem, in the case of `s.stop == 0`. So the given `Equivalent to` python code in the doc is not precisely equivalent to the c implementation. The doc needs a fix. ---------- nosy: +ysj.ray _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue11908> _______________________________________

Changes by Terry J. Reedy <tjreedy@udel.edu>: ---------- versions: -Python 2.5, Python 2.6, Python 3.4 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue11908> _______________________________________

Brian Brazil <brian.brazil@gmail.com> added the comment: The attached patch fixes this ---------- keywords: +patch nosy: +bbrazil Added file: http://bugs.python.org/file26283/issue11908-islice-docs.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue11908> _______________________________________

Changes by Mark Dickinson <dickinsm@gmail.com>: ---------- nosy: +mark.dickinson _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue11908> _______________________________________

Raymond Hettinger added the comment: ysj: The "equivalent" means "roughly equivalent" not "precisely equivalent". The purpose of the code in the docs is to help communicate what islice() is all about. Practicality beats purity in this regard. I know of no one who has ever been mislead by the islice() docs. I don't really like the proposed patch -- it improves a bit on technical accuracy but forgoes readability and still falls short on what stop=None does and on which arguments are required. That said, I don't really like the current version of the "roughly equivalent code either". It should probably be rewritten completely (no longer using slice() and it should show the actual looping logic. For clarity, it may be helpful to split it into two code-equivalents, one for the finite case (where stop is specified) and one for the infinite case (where stop is None). As it stands, the examples are beating the code equivalent when it comes to communicating what islice() does. I don't want to lengthen the code fragment unless it becomes *both* more communicative and more accurate. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue11908> _______________________________________

Changes by Terry J. Reedy <tjreedy@udel.edu>: ---------- versions: -Python 3.2 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue11908> _______________________________________