[issue28089] Document TCP_NODELAY by default
New submission from Ned Deily: This is marked as a release blocker but, since it's just a doc change, I'm not going to hold 3.6.0 for it. It would be nice to get it in, though. ---------- priority: release blocker -> deferred blocker _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
STINNER Victor added the comment: Yury: I don't understand your issue, can you please elaborate? Do you mean that the default value of the TCP_NODELAY changed in Python 3.6? Otherwise, why do you consider it as a release blocker? The Python 3.6 release must be blocked by a TCP flag? Really? ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
Mariatta Wijaya added the comment: The change is that TCP_NODELAY option is set by default in 3.6. It was not the case in 3.5. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
Changes by STINNER Victor <victor.stinner@gmail.com>: ---------- title: Document TCP_NODELAY by default -> asyncio: Document that TCP_NODELAY is now used by default _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
STINNER Victor added the comment:
The change is that TCP_NODELAY option is set by default in 3.6. It was not the case in 3.5.
Ah, it's a change in _asyncio_, ok. I missed that from the issue title, so I changed the title. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
Mariatta Wijaya added the comment: I added the following to Doc/library/asyncio-protocol.rst .. versionchanged:: 3.6.0 The socket option TCP_NODELAY is now set by default. Let me know if this patch works. ---------- keywords: +patch Added file: http://bugs.python.org/file45770/issue28089.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
Berker Peksag added the comment: +.. versionchanged:: 3.6.0 3.6.0 -> 3.6 + The socket option TCP_NODELAY is now set by default. TCP_NODELAY -> ``TCP_NODELAY`` ---------- nosy: +berker.peksag stage: needs patch -> patch review _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
Mariatta Wijaya added the comment: Thanks, Berker :) Updated. ---------- Added file: http://bugs.python.org/file45772/issue28089v2.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
Roundup Robot added the comment: New changeset 726308cfe3b5 by Victor Stinner in branch '3.6': catch_warnings() calls showwarning() if overriden https://hg.python.org/cpython/rev/726308cfe3b5 ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
Roundup Robot added the comment: New changeset 150d36dbe3ba by Victor Stinner in branch '3.6': warnings: Fix the issue number https://hg.python.org/cpython/rev/150d36dbe3ba ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
Ned Deily added the comment: Yury, look good to you? ---------- stage: patch review -> commit review versions: +Python 3.7 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
Roundup Robot added the comment: New changeset 853e3f4d6cd9 by Yury Selivanov in branch '3.6': Issue #28089: Document TCP_NODELAY in asyncio https://hg.python.org/cpython/rev/853e3f4d6cd9 New changeset 0d209cc7ffdc by Yury Selivanov in branch 'default': Merge 3.6 (issue #28089) https://hg.python.org/cpython/rev/0d209cc7ffdc ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
Yury Selivanov added the comment:
Yury, look good to you?
Yes; committed the patch with a small addition. Thanks, Mariatta! ---------- resolution: -> fixed stage: commit review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
Roundup Robot added the comment: New changeset dfd1019f75f9 by Yury Selivanov in branch '3.6': Issue #28089: Document TCP_NODELAY in asyncio https://hg.python.org/cpython/rev/dfd1019f75f9 ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
Ned Deily added the comment: [cherrypicked for 3.6.0rc2] ---------- priority: deferred blocker -> _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28089> _______________________________________
participants (6)
-
Berker Peksag -
Mariatta Wijaya
-
Ned Deily
-
Roundup Robot
-
STINNER Victor
-
Yury Selivanov