[issue23802] patch: __deepcopy__ memo dict argument usage
New submission from Daniel Shahaf: In the 'copy' module documentation, it wasn't fully clear to me how __deepcopy__ implementations should treat the memo dict argument. The attached patch clarifies that __deepcopy__ implementations should treat the memo dict argument as an opaque type. ---------- assignee: docs@python components: Documentation files: opaque.diff keywords: patch messages: 239473 nosy: danielsh, docs@python priority: normal severity: normal status: open title: patch: __deepcopy__ memo dict argument usage type: enhancement Added file: http://bugs.python.org/file38723/opaque.diff _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue23802> _______________________________________
R. David Murray added the comment: I would rather say simply "The memo dictionary should be treated as an opaque object". On the other hand, I doubt we will ever change the structure of the memo dict, because I'm sure that somewhere out there there is code that is *not* treating it as opaque :) ---------- nosy: +r.david.murray _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue23802> _______________________________________
Change by Joannah Nanjekye <nanjekyejoannah@gmail.com>: ---------- nosy: +nanjekyejoannah nosy_count: 3.0 -> 4.0 pull_requests: +20476 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21326 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23802> _______________________________________
Joannah Nanjekye <nanjekyejoannah@gmail.com> added the comment: The Pr should sort this. I will merge it tommorrow if there is no objection. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23802> _______________________________________
Joannah Nanjekye <nanjekyejoannah@gmail.com> added the comment: New changeset 3cbade7d309ab1ea97ec286d19d506df30bd1ab7 by Joannah Nanjekye in branch 'master': bpo-23802: patch: __deepcopy__ memo dict argument usage (GH-21326) https://github.com/python/cpython/commit/3cbade7d309ab1ea97ec286d19d506df30b... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23802> _______________________________________
Irit Katriel <iritkatriel@yahoo.com> added the comment: This seems resolved, can it be closed? ---------- nosy: +iritkatriel _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23802> _______________________________________
Change by Joannah Nanjekye <nanjekyejoannah@gmail.com>: ---------- stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23802> _______________________________________
participants (4)
-
Daniel Shahaf -
Irit Katriel
-
Joannah Nanjekye
-
R. David Murray