[issue12484] The Py_InitModule functions no longer exist, but remain in the docs
New submission from Alejandro Santos <alejolp@alejolp.com>: While the "Py_InitModule" does not exists on Py3k it is still mentioned on the docs: http://docs.python.org/py3k/extending/extending.html#keyword-parameters-for-... http://docs.python.org/py3k/extending/windows.html#a-cookbook-approach http://docs.python.org/py3k/faq/extending.html#what-does-systemerror-pyimpor... ---------- assignee: docs@python components: Documentation messages: 139728 nosy: alejolp, docs@python priority: normal severity: normal status: open title: The Py_InitModule functions no longer exist, but remain in the docs versions: Python 3.2 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Alejandro Santos <alejolp@alejolp.com> added the comment: The call is also present on the older 3.1 and "dev" release of the docs: http://docs.python.org/release/3.1.3/extending/extending.html#keyword-parame... http://docs.python.org/release/3.1.3/extending/windows.html#a-cookbook-appro... http://docs.python.org/release/3.1.3/faq/extending.html#what-does-systemerro... http://docs.python.org/dev/extending/extending.html#keyword-parameters-for-e... http://docs.python.org/dev/extending/windows.html#a-cookbook-approach http://docs.python.org/dev/faq/extending.html#what-does-systemerror-pyimport... ---------- versions: +Python 3.1, Python 3.3 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Changes by Senthil Kumaran <senthil@uthcode.com>: ---------- nosy: +orsenthil _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Anish Shah added the comment: will try to create a patch for this issue in a day. Thanks! ---------- nosy: +Anish.Shah _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Changes by Anish Shah <shah.anish07@gmail.com>: ---------- keywords: +patch Added file: http://bugs.python.org/file41310/remove_Py_InitModule_from_docs.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Changes by Zachary Ware <zachary.ware@gmail.com>: ---------- versions: +Python 3.4, Python 3.5, Python 3.6 -Python 3.1, Python 3.2, Python 3.3 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Terry J. Reedy added the comment: 3.4 is also on security fix only status. ---------- nosy: +terry.reedy versions: -Python 3.4 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Changes by Terry J. Reedy <tjreedy@udel.edu>: ---------- stage: -> needs patch type: -> behavior _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Terry J. Reedy added the comment: Sorry, another week for 3.4 ---------- versions: +Python 3.4 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Anish Shah added the comment: Can anyone review the patch? ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Berker Peksag added the comment: The patch looks good to me. _PyImport_FixupExtension does not exist in Python 3, but it's still documented in Doc/c-api/import.rst. We need to remove it, too. (Or we could document _PyImport_FixupExtensionObject since there are already documented internal functions in that file.) ---------- nosy: +berker.peksag, brett.cannon stage: needs patch -> patch review _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Anish Shah added the comment: It should be done in a separate issue, right? Or should I include it in this patch? ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Brett Cannon added the comment: Please do not document _PyImport_FixupExtensionObject(); documenting the internal functions was a mistake. As for whether _PyImport_FixupExtension() should be in this issue or another one, it doesn't matter, Anish; basically whatever is easiest for you if you want to do the work. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Anish Shah added the comment: @brett.cannon Thanks! I have updated the patch. I removed "_PyImport_FixupExtension" from docs. ---------- Added file: http://bugs.python.org/file41404/issue12484.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Changes by Brett Cannon <brett@python.org>: ---------- assignee: docs@python -> brett.cannon _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Roundup Robot added the comment: New changeset 003f1f60a09c by Brett Cannon in branch '3.5': Issue #12484: Remove a mention of Py_InitModule() and _PyImport_FixupExtension(). https://hg.python.org/cpython/rev/003f1f60a09c New changeset f4aee46c79ca by Brett Cannon in branch 'default': Merge for issue #12484 https://hg.python.org/cpython/rev/f4aee46c79ca ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
Brett Cannon added the comment: Thanks, Alejandro, for the report and Anish for the patch (who I added to Misc/ACKS)! ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12484> _______________________________________
participants (8)
-
Alejandro Santos -
Anish Shah
-
Berker Peksag
-
Brett Cannon
-
Roundup Robot
-
Senthil Kumaran
-
Terry J. Reedy
-
Zachary Ware