[issue12484] The Py_InitModule functions no longer exist, but remain in the docs
New submission from Alejandro Santos
Alejandro Santos
Changes by Senthil Kumaran
Anish Shah added the comment:
will try to create a patch for this issue in a day. Thanks!
----------
nosy: +Anish.Shah
_______________________________________
Python tracker
Changes by Anish Shah
Changes by Zachary Ware
Terry J. Reedy added the comment:
3.4 is also on security fix only status.
----------
nosy: +terry.reedy
versions: -Python 3.4
_______________________________________
Python tracker
Changes by Terry J. Reedy
Terry J. Reedy added the comment:
Sorry, another week for 3.4
----------
versions: +Python 3.4
_______________________________________
Python tracker
Anish Shah added the comment:
Can anyone review the patch?
----------
_______________________________________
Python tracker
Berker Peksag added the comment:
The patch looks good to me.
_PyImport_FixupExtension does not exist in Python 3, but it's still documented in Doc/c-api/import.rst. We need to remove it, too.
(Or we could document _PyImport_FixupExtensionObject since there are already documented internal functions in that file.)
----------
nosy: +berker.peksag, brett.cannon
stage: needs patch -> patch review
_______________________________________
Python tracker
Anish Shah added the comment:
It should be done in a separate issue, right?
Or should I include it in this patch?
----------
_______________________________________
Python tracker
Brett Cannon added the comment:
Please do not document _PyImport_FixupExtensionObject(); documenting the internal functions was a mistake.
As for whether _PyImport_FixupExtension() should be in this issue or another one, it doesn't matter, Anish; basically whatever is easiest for you if you want to do the work.
----------
_______________________________________
Python tracker
Anish Shah added the comment:
@brett.cannon Thanks! I have updated the patch. I removed "_PyImport_FixupExtension" from docs.
----------
Added file: http://bugs.python.org/file41404/issue12484.patch
_______________________________________
Python tracker
Changes by Brett Cannon
Roundup Robot added the comment:
New changeset 003f1f60a09c by Brett Cannon in branch '3.5':
Issue #12484: Remove a mention of Py_InitModule() and _PyImport_FixupExtension().
https://hg.python.org/cpython/rev/003f1f60a09c
New changeset f4aee46c79ca by Brett Cannon in branch 'default':
Merge for issue #12484
https://hg.python.org/cpython/rev/f4aee46c79ca
----------
nosy: +python-dev
_______________________________________
Python tracker
Brett Cannon added the comment:
Thanks, Alejandro, for the report and Anish for the patch (who I added to Misc/ACKS)!
----------
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
_______________________________________
Python tracker
participants (8)
-
Alejandro Santos
-
Anish Shah
-
Berker Peksag
-
Brett Cannon
-
Roundup Robot
-
Senthil Kumaran
-
Terry J. Reedy
-
Zachary Ware