[issue16682] Document that audioop works with bytes, not strings
New submission from Serhiy Storchaka: The audioop module documentation says that functions works with Python strings. This was right in 2.x, but in 3.x here should be bytes objects (actually the functions accept strings too, but this is an implementation detail, meaningless in general). ---------- assignee: docs@python components: Documentation messages: 177474 nosy: docs@python, serhiy.storchaka priority: normal severity: normal stage: patch review status: open title: Document that audioop works with bytes, not strings type: enhancement versions: Python 3.2, Python 3.3, Python 3.4 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16682> _______________________________________
Changes by Serhiy Storchaka <storchaka@gmail.com>: ---------- keywords: +patch Added file: http://bugs.python.org/file28312/audioop_docs_bytes.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16682> _______________________________________
Terry J. Reedy added the comment: Patch looks good to me, all three occurrences of 'string' are fixed. ---------- nosy: +terry.reedy stage: patch review -> commit review _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16682> _______________________________________
Changes by Serhiy Storchaka <storchaka@gmail.com>: ---------- assignee: docs@python -> serhiy.storchaka _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16682> _______________________________________
Roundup Robot added the comment: New changeset cd2b4074a2d9 by Serhiy Storchaka in branch '3.2': Issue #16682: Replace "Python string" to "bytes object" in audioop documentation. http://hg.python.org/cpython/rev/cd2b4074a2d9 New changeset e8248e597060 by Serhiy Storchaka in branch '3.3': Issue #16682: Replace "Python string" to "bytes object" in audioop documentation. http://hg.python.org/cpython/rev/e8248e597060 New changeset f68aeab64356 by Serhiy Storchaka in branch 'default': Issue #16682: Replace "Python string" to "bytes object" in audioop documentation. http://hg.python.org/cpython/rev/f68aeab64356 ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16682> _______________________________________
Changes by Serhiy Storchaka <storchaka@gmail.com>: ---------- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16682> _______________________________________
Changes by Serhiy Storchaka <storchaka@gmail.com>: ---------- keywords: +patch Added file: http://bugs.python.org/file28312/audioop_docs_bytes.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16682> _______________________________________
Terry J. Reedy added the comment: Patch looks good to me, all three occurrences of 'string' are fixed. ---------- nosy: +terry.reedy stage: patch review -> commit review _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16682> _______________________________________
Changes by Serhiy Storchaka <storchaka@gmail.com>: ---------- assignee: docs@python -> serhiy.storchaka _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16682> _______________________________________
Roundup Robot added the comment: New changeset cd2b4074a2d9 by Serhiy Storchaka in branch '3.2': Issue #16682: Replace "Python string" to "bytes object" in audioop documentation. http://hg.python.org/cpython/rev/cd2b4074a2d9 New changeset e8248e597060 by Serhiy Storchaka in branch '3.3': Issue #16682: Replace "Python string" to "bytes object" in audioop documentation. http://hg.python.org/cpython/rev/e8248e597060 New changeset f68aeab64356 by Serhiy Storchaka in branch 'default': Issue #16682: Replace "Python string" to "bytes object" in audioop documentation. http://hg.python.org/cpython/rev/f68aeab64356 ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16682> _______________________________________
Changes by Serhiy Storchaka <storchaka@gmail.com>: ---------- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16682> _______________________________________
participants (3)
-
Roundup Robot -
Serhiy Storchaka
-
Terry J. Reedy