[issue42042] docs.python.org for 3.10 missing the new refererence record.
New submission from Dong-hee Na <donghee.na92@gmail.com>: For example https://docs.python.org/3.10/c-api/bool.html?highlight=pydict_new#c.PyDict_N... should display `Return value: New reference.` but not, this looks like a regression bug. other version display `Return value: New reference.` very well. ---------- assignee: docs@python components: Documentation messages: 378677 nosy: corona10, docs@python, vstinner priority: normal severity: normal status: open title: docs.python.org for 3.10 missing the new refererence record. versions: Python 3.10 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Dong-hee Na <donghee.na92@gmail.com> added the comment: This is the regression bug caused by sphinx==3.2.1 If we roll back the sphinx version(2.4.4), it is okay. I am investigating what causes this issue. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Dong-hee Na <donghee.na92@gmail.com> added the comment: sphinx2 (Pdb) par[0].attributes {'ids': ['c._PyObject_New'], 'classes': [], 'names': ['c._PyObject_New'], 'dupnames': [], 'backrefs': [], 'first': False} sphinx3 (Pdb) par[0].attributes {'ids': ['c._PyObject_New'], 'classes': [], 'names': [], 'dupnames': [], 'backrefs': [], 'is_multiline': True} We are using the names attribute for annotation. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Change by Dong-hee Na <donghee.na92@gmail.com>: ---------- keywords: +patch pull_requests: +21702 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22739 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Dong-hee Na <donghee.na92@gmail.com> added the comment: One more regression is that code background highlight is not applied after sphinx version3 See https://docs.python.org/3.10/c-api/dict.html#c.PyDict_Next https://docs.python.org/3.9/c-api/dict.html#c.PyDict_Next ---------- stage: patch review -> _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Change by Dong-hee Na <donghee.na92@gmail.com>: ---------- nosy: +Mariatta _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Change by Dong-hee Na <donghee.na92@gmail.com>: ---------- title: docs.python.org for 3.10 missing the new refererence record. -> sphinx3 renders diffrently docs.python.org for 3.10 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Change by Karthikeyan Singaravelan <tir.karthi@gmail.com>: ---------- nosy: +mdk _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Dong-hee Na <donghee.na92@gmail.com> added the comment: Okay this is the theme bug. https://github.com/python/python-docs-theme/pull/57 ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Change by Dong-hee Na <donghee.na@python.org>: ---------- priority: normal -> release blocker _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Dong-hee Na <donghee.na@python.org> added the comment: @pablogsal Since this is the developer guide of 3.10. I would like to suggest as release bloker, if you don't agree you can change it ;) ---------- nosy: +pablogsal _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Pablo Galindo Salgado <pablogsal@gmail.com> added the comment:
I would like to suggest as release bloker, if you don't agree you can change it ;)
This is indeed a release blocker, but likely for the beta/release candidate phases. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Dong-hee Na <donghee.na@python.org> added the comment:
but likely for the beta/release candidate phases.
I think so too ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Change by STINNER Victor <vstinner@python.org>: ---------- nosy: -vstinner _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Dong-hee Na <donghee.na@python.org> added the comment: New changeset 09490a109faaee9cc393b52742a8575c116c56ba by Dong-hee Na in branch 'master': bpo-42042: Use ids attribute instead of names attribute (GH-22739) https://github.com/python/cpython/commit/09490a109faaee9cc393b52742a8575c116... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +22159 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23263 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Change by Dong-hee Na <donghee.na@python.org>: ---------- pull_requests: +22162 pull_request: https://github.com/python/cpython/pull/23265 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Change by Dong-hee Na <donghee.na@python.org>: ---------- nosy: +lukasz.langa versions: +Python 3.8, Python 3.9 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset 5ad468d4a8cfeb8a320659016964c23735c12a07 by Miss Islington (bot) in branch '3.8': bpo-42042: Use ids attribute instead of names attribute (GH-22739) https://github.com/python/cpython/commit/5ad468d4a8cfeb8a320659016964c23735c... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Dong-hee Na <donghee.na@python.org> added the comment: New changeset 0f4dd87a31130b245ec4c6ded9fd6f247e700c0d by Dong-hee Na in branch '3.9': [3.9] bpo-42042: Use ids attribute instead of names attribute (GH-22739) (GH-23265) https://github.com/python/cpython/commit/0f4dd87a31130b245ec4c6ded9fd6f247e7... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Change by Wendy Reynolds <reynoldsw347@gmail.com>: ---------- type: -> performance Added file: https://bugs.python.org/file49682/python-391.html _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Julien Palard <julien+python@palard.fr> added the comment: Is it fixed? ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Dong-hee Na <donghee.na@python.org> added the comment: @mdk No https://github.com/python/python-docs-theme/pull/57 must be fixed ;) ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Raymond Hettinger <raymond.hettinger@gmail.com> added the comment: The code background highlights really do need to be restored. Readability has been significantly impaired in 3.10. ---------- nosy: +rhettinger _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Pablo Galindo Salgado <pablogsal@gmail.com> added the comment: https://github.com/python/python-docs-theme/pull/57 is landed. We just need a new release of the package to pypi ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
Dong-hee Na <donghee.na@python.org> added the comment: @pablogsal @rhettinger @mdk @Mariatta Cool!! everything looks okay! Now I close this issue. Thank you to everyone who works on this issue!! ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue42042> _______________________________________
participants (8)
-
Dong-hee Na -
Julien Palard
-
Karthikeyan Singaravelan
-
miss-islington
-
Pablo Galindo Salgado
-
Raymond Hettinger
-
STINNER Victor
-
Wendy Reynolds