[issue35374] Windows doc build does not find autodetected hhc.exe
New submission from Christian Ullrich <chris@chrullrich.net>: If hhc.exe is on the PATH when HTML Help is being built, the build fails because make.bat does not correctly remember the fact. The set command is very finicky with trailing spaces, leading to this: '"hhc "' is not recognized as an internal or external command, operable program or batch file. I suppose the "official" build does not rely on autodetection. In that case, a better fix would be to require setting HTMLHELP explicitly. PR (for the single-character fix) incoming. ---------- assignee: docs@python components: Documentation messages: 330872 nosy: chrullrich, docs@python priority: normal severity: normal status: open title: Windows doc build does not find autodetected hhc.exe type: compile error _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35374> _______________________________________
Change by Christian Ullrich <chris@chrullrich.net>: ---------- keywords: +patch pull_requests: +10084 stage: -> patch review _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35374> _______________________________________
Change by Karthikeyan Singaravelan <tir.karthi@gmail.com>: ---------- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35374> _______________________________________
Change by Eryk Sun <eryksun@gmail.com>: ---------- nosy: +eryksun _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35374> _______________________________________
Steve Dower <steve.dower@python.org> added the comment: New changeset e61cc481e02b758c8d8289163102c236d0658a55 by Steve Dower (chrullrich) in branch 'master': bpo-35374: Avoid trailing space in hhc file name if found on PATH. (GH-10849) https://github.com/python/cpython/commit/e61cc481e02b758c8d8289163102c236d06... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35374> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +10950 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35374> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +10950, 10951 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35374> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +10950, 10951, 10952 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35374> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset 5d1e0124cf562153a681d1b5b362e7c8e23edea9 by Miss Islington (bot) in branch '3.7': bpo-35374: Avoid trailing space in hhc file name if found on PATH. (GH-10849) https://github.com/python/cpython/commit/5d1e0124cf562153a681d1b5b362e7c8e23... ---------- nosy: +miss-islington _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35374> _______________________________________
Change by Steve Dower <steve.dower@python.org>: ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35374> _______________________________________
participants (5)
-
Christian Ullrich -
Eryk Sun
-
Karthikeyan Singaravelan
-
miss-islington
-
Steve Dower