[issue35946] Ambiguous documentation for assert_called_with()
New submission from Mark Forrer <mark.forrer@lbl.gov>: The documentation for assert_called_with() is ambiguous with regard to the fact that the method only checks the most recent call. This behavior for assert_called_with() is only documented under assert_any_call(), which users are unlikely to read when making quick reference to the documentation. ---------- assignee: docs@python components: Documentation messages: 335112 nosy: chimaerase, docs@python priority: normal severity: normal status: open title: Ambiguous documentation for assert_called_with() versions: Python 3.7 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35946> _______________________________________
Change by Rémi Lapeyre <remi.lapeyre@henki.fr>: ---------- keywords: +patch pull_requests: +11800 stage: -> patch review _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35946> _______________________________________
Change by Rémi Lapeyre <remi.lapeyre@henki.fr>: ---------- keywords: +patch, patch pull_requests: +11800, 11801 stage: -> patch review _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35946> _______________________________________
Change by Rémi Lapeyre <remi.lapeyre@henki.fr>: ---------- keywords: +patch, patch, patch pull_requests: +11800, 11801, 11802 stage: -> patch review _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35946> _______________________________________
Rémi Lapeyre <remi.lapeyre@henki.fr> added the comment: Hi Mark Forrer, I opened a new PR to add this precision to assert_called_with documentation. ---------- nosy: +remi.lapeyre versions: +Python 3.8 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35946> _______________________________________
Mark Forrer <mark.forrer@lbl.gov> added the comment: Thank you Rémi! Thanks, --Mark-- On Fri, Feb 8, 2019 at 2:39 PM Rémi Lapeyre <report@bugs.python.org> wrote:
Rémi Lapeyre <remi.lapeyre@henki.fr> added the comment:
Hi Mark Forrer, I opened a new PR to add this precision to assert_called_with documentation.
---------- nosy: +remi.lapeyre versions: +Python 3.8
_______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35946> _______________________________________
---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35946> _______________________________________
Ned Deily <nad@python.org> added the comment: New changeset f5896a05edf5df91fb1b55bd481ba5b2a3682f4e by Ned Deily (Rémi Lapeyre) in branch 'master': bpo-35946: Improve assert_called_with documentation (GH-11796) https://github.com/python/cpython/commit/f5896a05edf5df91fb1b55bd481ba5b2a36... ---------- nosy: +ned.deily _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35946> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +15255 pull_request: https://github.com/python/cpython/pull/15579 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35946> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset 612d3935ec0b2fbe88b3fae8167f0c503c61a9ca by Miss Islington (bot) in branch '3.8': bpo-35946: Improve assert_called_with documentation (GH-11796) https://github.com/python/cpython/commit/612d3935ec0b2fbe88b3fae8167f0c503c6... ---------- nosy: +miss-islington _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35946> _______________________________________
Ned Deily <nad@python.org> added the comment: Thanks for the report and thanks for the PR! Merged for 3.8.0b4. ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 -Python 3.7 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35946> _______________________________________
participants (4)
-
Mark Forrer -
miss-islington
-
Ned Deily
-
Rémi Lapeyre