[issue31811] async and await missing from keyword list in lexical analysis doc
New submission from Colin Dunklau <colin.dunklau@gmail.com>: I see that code making async/await real keywords has been merged, but it looks like Doc/reference/lexical_analysis.rst doesn't have those added https://github.com/python/cpython/blob/4a2d00c/Doc/reference/lexical_analysi... Is that list autogenerated somehow or was it just overlooked? ---------- assignee: docs@python components: Documentation messages: 304583 nosy: Colin Dunklau, docs@python priority: normal severity: normal status: open title: async and await missing from keyword list in lexical analysis doc type: enhancement versions: Python 3.7 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31811> _______________________________________
F. Lamar <lamar.frankie@gmail.com> added the comment: I a new contributor. This seems like a simple fix. I'd be happy to work on it. I will submit ar PR on or before 10-22-17 ---------- nosy: +F. Lamar _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31811> _______________________________________
Change by Terry J. Reedy <tjreedy@udel.edu>: ---------- nosy: +yselivanov _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31811> _______________________________________
Yury Selivanov <yselivanov@gmail.com> added the comment: They are covered here: https://github.com/python/cpython/blob/4a2d00cb4525fcb3209f04531472ba6a359ed... ---------- resolution: -> not a bug stage: -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31811> _______________________________________
Colin Dunklau <colin.dunklau@gmail.com> added the comment: Hi Yury, perhaps I've misinterpreted PEP 492, and I can't claim to understand how the parser works and thus how the changes in https://github.com/python/cpython/pull/1669 affect things, but it seems to me that async and await are truly reserved words now, not just only reserved in certain contexts. If that's true, shouldn't they also appear in the list in the lexical analysis doc? I'd appreciate any clarification you (or anyone else) can offer. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31811> _______________________________________
Yury Selivanov <yselivanov@gmail.com> added the comment: Ah, you mean this list: https://docs.python.org/3/reference/lexical_analysis.html#keywords ? Your original link was a bit hard to read as it shows rest markup and not the actual list of keywords. So I missed it, sorry. I'll reopen the issue, please feel free to submit a PR! ---------- resolution: not a bug -> stage: resolved -> needs patch status: closed -> open _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31811> _______________________________________
Change by Tom Floyer <tomfloyer@icloud.com>: ---------- keywords: +patch pull_requests: +4095 stage: needs patch -> patch review _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31811> _______________________________________
Tom Floyer <tomfloyer@icloud.com> added the comment: I've added those keywords to documentation master branch. ---------- nosy: +tomfloyer pull_requests: +4104 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31811> _______________________________________
Change by Tom Floyer <tomfloyer@icloud.com>: ---------- pull_requests: -4095 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31811> _______________________________________
Change by Yury Selivanov <yselivanov@gmail.com>: ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31811> _______________________________________
STINNER Victor <victor.stinner@gmail.com> added the comment: The final commit uses the wrong bpo number: New changeset bf9d317626eebcf79bd0756b4dd43df82d5cc186 by Yury Selivanov (Tom Floyer) in branch 'master': bpo-31810: added missing keywords to docs. (#4140) https://github.com/python/cpython/commit/bf9d317626eebcf79bd0756b4dd43df82d5... ---------- nosy: +haypo _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31811> _______________________________________
participants (6)
-
Colin Dunklau
-
F. Lamar
-
STINNER Victor
-
Terry J. Reedy
-
Tom Floyer
-
Yury Selivanov