Terry J. Reedy added the comment: Doc/howto/doanddont.rst is the source for Python HOWTOs: Idioms and Anti-Idioms in Python Moshe Zadka original author (added as nosy) The gist of the patch is to clarify that using 'with' is best, not the non-with version that is currently called both 'best' and 'not very good'. I agreed that the current version is confusing and the patch or something like it should be applied. Floris: 2.6 is closed to non-critical patches. 3.3 is for patches that cannot be applied sooner. ---------- nosy: +moshez, terry.reedy stage: -> patch review type: feature request -> behavior versions: -Python 2.6, Python 3.3 _______________________________________ Python tracker http://bugs.python.org/issue9608 _______________________________________

Éric Araujo added the comment: Your rewrite makes the text much clearer in my opinion. Here are some nits for you to grind, cheers :) 1) I’d say “using a bare ``except:``” and maybe add an index entry for “bare except” referring to that section, to make indexing and maybe googling find this. 2) To make the bad examples clearer, I would remove the second inline comment (“will be changed as soon as we run it”). The wording is confusing: Does that mean the code will be changed by Python at runtime? The text after this code example is clear enough, this comment doesn’t help. 3) “except catches all errors, including GeneratorExit which is not even an error”: Isn’t this confusing for beginners? ---------- nosy: +eric.araujo _______________________________________ Python tracker http://bugs.python.org/issue9608 _______________________________________

Éric Araujo added the comment: It would. ---------- _______________________________________ Python tracker http://bugs.python.org/issue9608 _______________________________________

R. David Murray added the comment: Committed in r84719 and r84720, backported to 2.7 in r84721 with the addition of a sentence admitting that sometimes you need a bare except to catch third-party exceptions that don't inherit from Exception. ---------- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed _______________________________________ Python tracker http://bugs.python.org/issue9608 _______________________________________

Changes by Éric Araujo : ---------- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed _______________________________________ Python tracker http://bugs.python.org/issue9608 _______________________________________